Bugzilla – Attachment 96244 Details for
Bug 24230
intranet_js plugin hook is after body end tag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24230: fix intranet_js plugin hook before body end tag
Bug-24230-fix-intranetjs-plugin-hook-before-body-e.patch (text/plain), 1.40 KB, created by
Marcel de Rooy
on 2019-12-13 10:21:05 UTC
(
hide
)
Description:
Bug 24230: fix intranet_js plugin hook before body end tag
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-12-13 10:21:05 UTC
Size:
1.40 KB
patch
obsolete
>From c519fe4dbba01cc0d974cf34f20d9897cbcf1e01 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 13 Dec 2019 07:01:23 +0100 >Subject: [PATCH] Bug 24230: fix intranet_js plugin hook before body end tag >Content-Type: text/plain; charset=utf-8 > >The plugin hook intranet_js is after body tag in intranet-bottom.inc : > </body> >[% KohaPlugins.get_plugins_intranet_js | $raw %] ></html> > >It must be before like in opac-bottom.inc > >Test plan : >1) Install a Koha plugin with intranet_js hook, like KitechenSink >2) Go to an intranet page >3) Look at source of the page to see plugin code is before body end tag > >Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >index 89a487086a..e0bce02522 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >@@ -72,6 +72,6 @@ > [% INCLUDE js_includes.inc %] > [% jsinclude | $raw # Parse the page template's JavaScript block if necessary %] > [% END %] >- </body> > [% KohaPlugins.get_plugins_intranet_js | $raw %] >+</body> > </html> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24230
:
96236
|
96239
| 96244