Attachment 96291 Details for Bug 24046 – Bug 24046: Untranslatable 'Activate filters'

[patch] Bug 24046: Untranslatable 'Activate filters'

Bug-24046-Untranslatable-Activate-filters.patch (text/plain), 2.48 KB, created by Jonathan Druart on 2019-12-15 11:14:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-15 11:14:09 UTC

Size: 2.48 KB

patch

obsolete

>From 37fece5fb9b8d3930d6edc8f2c89bace21016d2a Mon Sep 17 00:00:00 2001
>From: Maryse Simard <maryse.simard@inlibro.com>
>Date: Mon, 18 Nov 2019 08:50:52 -0500
>Subject: [PATCH] Bug 24046: Untranslatable 'Activate filters'
>
>Bug 9573 moved the code for the table filters activation to it's
>own javascript file. The strings contained in this file are not
>translatable. This patch moves the strings to the datatables
>include file since the filters are related to datatables.
>
>Test plan:
>Visit the catalogue/detail.pl and reports/itemslost.pl and test
>that the 'Activate/Deactivate filters' option still work correctly.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc | 2 ++
> koha-tmpl/intranet-tmpl/prog/js/table_filters.js | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
>index ba57f32b31..cf0043e545 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
>@@ -23,5 +23,7 @@
> var MSG_DT_COPY_SUCCESS_ONE = _("Copied one row to clipboard");
> var MSG_DT_COPY_SUCCESS_X = _("Copied %d rows to clipboard");
> var MSG_CLEAR_FILTER = _("Clear filter");
>+ var MSG_ACTIVATE_FILTERS = _("Activate filters");
>+ var MSG_DEACTIVATE_FILTERS = _("Deactivate filters");
> </script>
> [% Asset.js("js/datatables.js") | $raw %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/table_filters.js b/koha-tmpl/intranet-tmpl/prog/js/table_filters.js
>index 6607120d35..d7c4dc8988 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/table_filters.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/table_filters.js
>@@ -23,7 +23,7 @@ function activate_filters(id) {
> }
> 
> $('#' + id + '_activate_filters')
>- .html(' ' + _("Deactivate filters") )
>+ .html(' ' + MSG_DEACTIVATE_FILTERS )
> .unbind('click')
> .click(function() {
> deactivate_filters(id);
>@@ -41,7 +41,7 @@ function deactivate_filters(id) {
> filters_row.hide();
> 
> $('#' + id + '_activate_filters')
>- .html(' ' + _("Activate filters") )
>+ .html(' ' + MSG_ACTIVATE_FILTERS )
> .unbind('click')
> .click(function() {
> activate_filters(id);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24046: 95437 | 95514 | 96231 | 96285 | 96291