Attachment 96321 Details for Bug 7047 – Bug 7047: (QA follow-up) Fix tests

[patch] Bug 7047: (QA follow-up) Fix tests

Bug-7047-QA-follow-up-Fix-tests.patch (text/plain), 1.70 KB, created by Nick Clemens (kidclamp) on 2019-12-16 11:47:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-12-16 11:47:25 UTC

Size: 1.70 KB

patch

obsolete

>From ee3f8b7cba2155c3c671a083deca8e3eb045a594 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 16 Dec 2019 11:45:51 +0000
>Subject: [PATCH] Bug 7047: (QA follow-up) Fix tests
>
>Tests fail on biblionumber constraint for suggestions if 'RenewSerialAddsSuggestion' is enabled
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> t/db_dependent/Serials/ReNewSubscription.t | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Serials/ReNewSubscription.t b/t/db_dependent/Serials/ReNewSubscription.t
>index d4331ceb0d..73affa201c 100644
>--- a/t/db_dependent/Serials/ReNewSubscription.t
>+++ b/t/db_dependent/Serials/ReNewSubscription.t
>@@ -58,11 +58,13 @@ my $pattern = $builder->build({
>     }
> });
> 
>+my $biblio = $builder->build_sample_biblio();
>+
> # Create fake subscription, daily subscription, duration 12 months, issues startint at #100
> my $subscription = $builder->build({
>     source => 'Subscription',
>     value  => {
>-        biblionumber    => 1,
>+        biblionumber    => $biblio->biblionumber,
>         startdate       => '2015-01-01',
>         enddate         => '2015-12-31',
>         aqbooksellerid  => 1,
>@@ -75,6 +77,7 @@ my $subscription = $builder->build({
> my $subscriptionhistory = $builder->build({
>     source => 'Subscriptionhistory',
>     value  => {
>+        biblionumber   => $biblio->biblionumber,
>         subscriptionid => $subscription->{subscriptionid},
>         histenddate    => undef,
>         opacnote       => 'Testing',
>@@ -82,7 +85,6 @@ my $subscriptionhistory = $builder->build({
> });
> 
> # Actual testing starts here!
>-
> # Renew the subscription and check that enddate has not been set
> ReNewSubscription(
>     {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 7047: 69474 | 71168 | 72639 | 96309 | 96310 | 96311 | 96317 | 96318 | 96319 | 96320 | 96321 | 96585 | 96586 | 96587 | 96588 | 96589