Bugzilla – Attachment 96330 Details for
Bug 14973
Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14973: Add missing filters in templates
Bug-14973-Add-missing-filters-in-templates.patch (text/plain), 13.86 KB, created by
Nick Clemens (kidclamp)
on 2019-12-16 12:42:14 UTC
(
hide
)
Description:
Bug 14973: Add missing filters in templates
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-12-16 12:42:14 UTC
Size:
13.86 KB
patch
obsolete
>From 884e1e8566207fe6ab621018e77d2be7f9896a3d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 6 Nov 2019 17:25:57 +0100 >Subject: [PATCH] Bug 14973: Add missing filters in templates > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > .../prog/en/modules/suggestion/suggestion.tt | 8 ++--- > .../bootstrap/en/modules/opac-suggestions.tt | 38 +++++++++++----------- > 2 files changed, 23 insertions(+), 23 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index fead7f4474..e3d9631f86 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -240,12 +240,12 @@ > > [% IF ( op_save ) %] > [% FOR m IN messages %] >- <div class="dialog [% m.type %]"> >+ <div class="dialog [% m.type | html %]"> > [% SWITCH m.code %] > [% CASE 'biblio_exists' %] >- A similar document already exists: <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% m.id %]">[% m.title %]</a>. Click on "Confirm your suggestion" to ignore this message. >+ A similar document already exists: <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% m.id | uri %]">[% m.title | html %]</a>. Click on "Confirm your suggestion" to ignore this message. > [% CASE %] >- [% m.code %] >+ [% m.code | html %] > [% END %] > </div> > [% END %] >@@ -457,7 +457,7 @@ > [% CASE 'already_exists' %] > The suggestion has not been added. A suggestion with this title already exists (<a href='/cgi-bin/koha/suggestion/suggestion.pl?suggestionid=[% m.id | html %]&op=show'>suggestion #[% m.id | html %]</a>) > [% CASE 'biblio_exists' %] >- A similar document already exists: <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% m.id %]">[% m.title %]</a>. Click on "Confirm your suggestion" to ignore this message. >+ A similar document already exists: <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% m.id | uri %]">[% m.title | html %]</a>. Click on "Confirm your suggestion" to ignore this message. > [% CASE %] > [% m.code | html %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 7650af864a..db6d7ce420 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -41,12 +41,12 @@ > <p>Only certain fields (marked in red) are required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. The "Notes" field can be used to provide any additional information.</p> > > [% FOR m IN messages %] >- <div class="alert alert-[% m.type %]"> >+ <div class="alert alert-[% m.type | html %]"> > [% SWITCH m.code %] > [% CASE 'biblio_exists' %] >- A similar document already exists: <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% m.id %]">[% m.title %]</a>. Click on "Confirm your suggestion" to ignore this message. >+ A similar document already exists: <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% m.id | uri %]">[% m.title | html %]</a>. Click on "Confirm your suggestion" to ignore this message. > [% CASE %] >- [% m.code %] >+ [% m.code | html %] > [% END %] > </div> > [% END %] >@@ -57,73 +57,73 @@ > <li> > [% IF ( title_required ) %] > <label for="title" class="required">Title:</label> >- <input type="text" id="title" name="title" class="span6" maxlength="255" value="[% title %]" required="required" /> >+ <input type="text" id="title" name="title" class="span6" maxlength="255" value="[% title | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] > <label for="title">Title:</label> >- <input type="text" id="title" name="title" class="span6" maxlength="255" value="[% title %]" /> >+ <input type="text" id="title" name="title" class="span6" maxlength="255" value="[% title | html %]" /> > [% END %] > </li> > <li> > [% IF ( author_required ) %] > <label for="author" class="required">Author:</label> >- <input type="text" id="author" name="author" class="span6" maxlength="80" value="[% author %]" required="required" /> >+ <input type="text" id="author" name="author" class="span6" maxlength="80" value="[% author | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] > <label for="author">Author:</label> >- <input type="text" id="author" name="author" class="span6" maxlength="80" value="[% author %]" /> >+ <input type="text" id="author" name="author" class="span6" maxlength="80" value="[% author | html %]" /> > [% END %] > </li> > <li> > <div title="Copyright or publication year, for example: 2016"> > [% IF ( copyrightdate_required ) %] > <label for="copyrightdate" class="required">Copyright date:</label> >- <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" maxlength="4" value="[% copyrightdate %]" required="required" /> >+ <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" maxlength="4" value="[% copyrightdate | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] > <label for="copyrightdate">Copyright date:</label> >- <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" maxlength="4" value="[% copyrightdate %]" /> >+ <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" maxlength="4" value="[% copyrightdate | html %]" /> > [% END %] > </div> > </li> > <li> > [% IF ( isbn_required ) %] > <label for="isbn" class="required">Standard number (ISBN, ISSN or other):</label> >- <input type="text" id="isbn" name="isbn" maxlength="80" value="[% isbn %]" required="required" /> >+ <input type="text" id="isbn" name="isbn" maxlength="80" value="[% isbn | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] > <label for="isbn">Standard number (ISBN, ISSN or other):</label> >- <input type="text" id="isbn" name="isbn" maxlength="80" value="[% isbn %]" /> >+ <input type="text" id="isbn" name="isbn" maxlength="80" value="[% isbn | html %]" /> > [% END %] > </li> > <li> > [% IF ( publishercode_required ) %] > <label for="publishercode" class="required">Publisher:</label> >- <input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" value="[% publishercode %]" required="required" /> >+ <input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" value="[% publishercode | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] > <label for="publishercode">Publisher:</label> >- <input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" value="[% publishercode %]" /> >+ <input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" value="[% publishercode | html %]" /> > [% END %] > </li> > <li> > [% IF ( collectiontitle_required ) %] > <label for="collectiontitle" class="required">Collection title:</label> >- <input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" value="[% collectiontitle %]" required="required" /> >+ <input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" value="[% collectiontitle | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] > <label for="collectiontitle">Collection title:</label> >- <input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" value="[% collectiontitle %]" /> >+ <input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" value="[% collectiontitle | html %]" /> > [% END %] > </li> > <li> > [% IF ( place_required ) %] > <label for="place" class="required">Publication place:</label> >- <input type="text" id="place" name="place" required="required" maxlength="80" value="[% place %]" /> >+ <input type="text" id="place" name="place" required="required" maxlength="80" value="[% place | html %]" /> > <span class="required">Required</span> > [% ELSE %] > <label for="place">Publication place:</label> >- <input type="text" id="place" name="place" maxlength="80" value="[% place %]" /> >+ <input type="text" id="place" name="place" maxlength="80" value="[% place | html %]" /> > [% END %] > </li> > <li id="opac-suggestion-quantity"> >@@ -187,11 +187,11 @@ > <li> > [% IF ( note_required ) %] > <label for="note" class="required">Notes:</label> >- <textarea name="note" id="note" rows="5" cols="40" required="required">[% note %]</textarea> >+ <textarea name="note" id="note" rows="5" cols="40" required="required">[% note | html %]</textarea> > <span class="required">Required</span> > [% ELSE %] > <label for="note">Notes:</label> >- <textarea name="note" id="note" rows="5" cols="40">[% note %]</textarea> >+ <textarea name="note" id="note" rows="5" cols="40">[% note | html %]</textarea> > [% END %] > </li> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14973
:
43193
|
44091
|
44319
|
44320
|
44334
|
44335
|
60877
|
60913
|
93141
|
93142
|
94297
|
94298
|
94301
|
94302
|
94303
|
94304
|
95113
|
95114
|
95517
|
96255
|
96256
|
96257
|
96258
|
96259
|
96260
|
96261
|
96325
|
96326
|
96327
|
96328
|
96329
| 96330 |
96331