Attachment 96337 Details for Bug 23889 – Bug 23889: Improve style of menu header in advanced cataloging editor

[patch] Bug 23889: Improve style of menu header in advanced cataloging editor

Bug-23889-Improve-style-of-menu-header-in-advanced.patch (text/plain), 2.94 KB, created by Jonathan Druart on 2019-12-16 14:12:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-16 14:12:13 UTC

Size: 2.94 KB

patch

obsolete

>From 30c06352261ee184ddb218b69e0b5918dbdee33f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 24 Oct 2019 14:15:41 +0000
>Subject: [PATCH] Bug 23889: Improve style of menu header in advanced
> cataloging editor
>
>This patch updates the style of dropdown menu headers to make it apply
>more globally and changes the advanced cataloging editor template so
>that the correct class is applied to the menu header.
>
>To test, apply the patch and rebuild the staff client CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>
>Test the interfaces where these kinds of menu headers can be found:
>
> - Catalog search results: The "Sort" menu (Popularity, Author, etc.
>   headings).
>
> - Saved report results: Run a report which returns a column of
>   biblionumbers or itemnumbers. Check the "Batch operations" menu
>   (Bibliographic records or item records headings).
>
> - Advanced cataloging editor: The settings menu (Change framework
>   header).
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../intranet-tmpl/prog/css/src/staff-global.scss     | 20 ++++++++++++--------
> .../prog/en/modules/cataloguing/editor.tt            |  2 +-
> 2 files changed, 13 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 950da22f35..d00f27257e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -2037,14 +2037,6 @@ li {
>             padding: 5px 25em 0 0;
>         }
>     }
>-
>-    .dropdown-header {
>-        border-top: 1px solid #EEE;
>-        color: #000;
>-        font-weight: bold;
>-        padding-left: 10px;
>-    }
>-
> }
> 
> #search-facets {
>@@ -2966,6 +2958,18 @@ video {
> 
> // Bootstrap overrides
> 
>+.dropdown-header {
>+    border-top: 1px solid #EEE;
>+    color: #000;
>+    font-weight: bold;
>+    margin-top: 5px;
>+    padding-left: 10px;
>+
>+    &:first-child {
>+        border-top: 0;
>+    }
>+}
>+
> nav {
>     background: #E6F0F2 none;
>     border: 0;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
>index f75fee2e9d..30327957ff 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
>@@ -46,7 +46,7 @@
>             <ul id="prefs-menu" class="dropdown-menu">
>                 <li><a id="switch-editor" href="#">Switch to basic editor</a></li>
>                 <li><a id="set-field-widgets" href="#"></a></li>
>-                <li class="nav-header">Change framework</li>
>+                <li class="dropdown-header">Change framework</li>
>                 <li>
>                     <a class="change-framework" data-frameworkcode="">
>                         <i class="fa fa-fw unselected">&nbsp;</i>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23889: 94677 | 94679 | 94977 | 96337 | 96338