Attachment 96344 Details for Bug 7882 – Bug 7882: Add ability to move and reorder fields in MARC editor

[patch] Bug 7882: Add ability to move and reorder fields in MARC editor

Bug-7882-Add-ability-to-move-and-reorder-fields-in.patch (text/plain), 23.58 KB, created by Jonathan Druart on 2019-12-16 14:58:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-16 14:58:31 UTC

Size: 23.58 KB

patch

obsolete

>From f6620ca729e114f921fd619cf8ee7900bbf7f037 Mon Sep 17 00:00:00 2001
>From: Maryse Simard <maryse.simard@inlibro.com>
>Date: Wed, 23 Oct 2019 15:34:39 -0400
>Subject: [PATCH] Bug 7882: Add ability to move and reorder fields in MARC
> editor
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Use jQueryUI sortable to make fields and subfields moveable in the
>MARC editor for both records and authorities.
>
>This patch convert items from div's to ul's and consequently alter css
>and js to match. It also replace the up arrow with a more adapted icon
>(from font awesome).
>
>Primary authorship by Elliott Davis.
>
>To Test:
>
>1. Add or edit a record in cataloguing module.
>2. You should be able to move the fields and subfields around.
>    - You can click on any part of the element to drag it, the move
>    icon to the left of the item is a good place to do it.
>    => You can only change the order of fields of the same tag.
>3. Make sure all of the javascript driven fonctionnality still work :
>    - Duplicate fields/subfields
>    - Remove fields/subfields
>    - Using the tag editor for control fields or to link authorities
>    - etc
>4. Reorder some fields/subfields and save the record.
>5. Edit the record again.
>6. The order in the editor should match the changes which were saved.
>    - Empty subfields should appear after the ones with content.
>7. Repeat steps 1-6 with the authority editor.
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> cataloguing/addbiblio.pl                           |   2 +-
> koha-tmpl/intranet-tmpl/prog/css/addbiblio.css     |  51 ++++++++++++++++++--
> .../prog/en/modules/authorities/authorities.tt     |  28 +++++++----
> .../authorities/blinddetail-biblio-search.tt       |   6 +--
> .../prog/en/modules/cataloguing/addbiblio.tt       |  28 +++++++----
> koha-tmpl/intranet-tmpl/prog/img/up.png            | Bin 362 -> 0 bytes
> koha-tmpl/intranet-tmpl/prog/js/cataloging.js      |  52 +++++++++------------
> 7 files changed, 108 insertions(+), 59 deletions(-)
> delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/up.png
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 00b250190a..a548bab8a6 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -511,7 +511,7 @@ sub build_tabs {
>     for ( my $tabloop = 0 ; $tabloop <= $max_num_tab ; $tabloop++ ) {
>         my @loop_data = (); #innerloop in the template.
>         my $i = 0;
>-        foreach my $tag (@tab_data) {
>+        foreach my $tag (sort @tab_data) {
>             $i++;
>             next if ! $tag;
>             my ($indicator1, $indicator2);
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>index 9fdbedb93c..28cf3414c2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>@@ -15,6 +15,49 @@ div#toolbar {
>     margin: .3em 0;
> }
> 
>+ul.sortable_field, ul.sortable_subfield {
>+    margin-bottom: 0;
>+    padding-left: 0;
>+}
>+
>+ul li.tag, ul li.tag li.subfield_line {
>+    list-style-type: none;
>+    position: relative;
>+    padding-left: 30px;
>+}
>+
>+ul li.tag:before, ul li.tag li.subfield_line:before {
>+    position: absolute;
>+    font-family: 'FontAwesome';
>+    font-size: .8em;
>+    top: 0;
>+    left: 10px;
>+    content: "\f047";
>+}
>+
>+ul li.tag:before {
>+    padding-top: 1.7em;
>+}
>+
>+li.ui-sortable-helper {
>+    background-color: #e0e0e0;
>+    max-height: 150px;
>+    padding: 2px;
>+    border-radius: 4px;
>+}
>+
>+li.ui-sortable-helper ul li {
>+	display: none !important;
>+}
>+
>+.sortable_subfield .ui-sortable-helper input.flat {
>+	background-color: transparent;
>+}
>+
>+ul li.tag li.subfield_line.ui-sortable-helper::before {
>+    top: 5px;
>+}
>+
> .buttonPlus {
> 	font-weight : bold;
> 	text-decoration : none;
>@@ -44,14 +87,14 @@ a.expandfield {
>     padding: .7em 0;
> }
> 
>-div.subfield_line {
>+li.subfield_line {
>     padding-bottom: .3em;
>     float: left;
>     clear: left;
>     width: 100%;
> }
> 
>-div.subfield_line label {
>+li.subfield_line label {
>     font-size:89%;
>     float: left;
> 	 padding-right : .4em;
>@@ -266,7 +309,7 @@ tbody tr.active td {
> }
> 
> @media (min-width: 768px) {
>-    div.subfield_line label {
>+    li.subfield_line label {
>         width: 20em;
>     }
> 
>@@ -280,7 +323,7 @@ tbody tr.active td {
> }
> 
> @media (min-width: 1200px) {
>-    div.subfield_line label {
>+    li.subfield_line label {
>         width: 25em;
>     }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index 51f4b2af84..bf2dffc6ca 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -12,7 +12,9 @@
>     });
>     var Sticky;
> 	 $(document).ready(function() {
>-        $('#authoritytabs').tabs();
>+        var tabs = $('#authoritytabs').tabs();
>+        $( "ul.sortable_field", tabs ).sortable();
>+        $( "ul.sortable_subfield", tabs ).sortable();
>         Sticky = $("#toolbar");
>         Sticky.hcSticky({
>             stickTo: ".main",
>@@ -235,9 +237,17 @@ function confirmnotdup(redirect){
> [% FOREACH BIG_LOO IN BIG_LOOP %]
>     <div id="tab[% BIG_LOO.number | html %]XX">
> 
>+    [% previous = "" %]
>     [% FOREACH innerloo IN BIG_LOO.innerloop %]
>     [% IF ( innerloo.tag ) %]
>-    <div class="tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>+    [% IF innerloo.tag != previous %]
>+        [% IF previous != "" %]
>+            </ul>
>+        [% END %]
>+        [% previous = innerloo.tag %]
>+        <ul class="sortable_field">
>+    [% END %]
>+    <li class="tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>         <div class="tag_title" id="div_indicator_tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>         [% UNLESS hide_marc %]
>             [% IF advancedMARCEditor %]
>@@ -316,9 +326,10 @@ function confirmnotdup(redirect){
> 
>         </div>
> 
>+        <ul class="sortable_subfield">
>         [% FOREACH subfield_loo IN innerloo.subfield_loop %]
>             
>-            <div class="subfield_line" style="[% subfield_loo.visibility | html %]" id="subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]">
>+            <li class="subfield_line" style="[% subfield_loo.visibility | html %]" id="subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]">
> 
>                 [% UNLESS advancedMARCEditor %]
>                     [% IF ( subfield_loo.fixedfield ) %]<label for="tag_[% subfield_loo.tag | html %]_subfield_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" style="display:none;" class="labelsubfield">
>@@ -328,11 +339,6 @@ function confirmnotdup(redirect){
>                 
>                 [% UNLESS hide_marc %]
>                 <span class="subfieldcode">
>-                    [% IF ( subfield_loo.fixedfield ) %]
>-                        <img class="buttonUp" style="display:none;" src="[% interface | html %]/[% theme | html %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]')" alt="Move Up" title="Move Up" />
>-                    [% ELSE %]
>-                        <img class="buttonUp" src="[% interface | html %]/[% theme | html %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]')" alt="Move Up" title="Move Up" />
>-                    [% END %]
>                         <input type="text"
>                             title="[% subfield_loo.marc_lib | $raw %]"
>                             style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;"
>@@ -400,12 +406,14 @@ function confirmnotdup(redirect){
>                 [% END %]
>                 </span>
>                 
>-            </div>
>+            </li>
>             
>         [% END %]
> 
>-    </div>
>+        </ul> 
>+    </li>
>     [% END %]
>+    </ul> 
>     [% END %]
>     </div>
> [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
>index b9635b372a..6822225ea9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
>@@ -46,7 +46,7 @@
>             } catch(e) {
>                 return;
>             }
>-            var field_start = whichfield.parentNode.parentNode;
>+            var field_start = whichfield.parentNode.parentNode.parentNode;
> 
>             // Sets the good number of form fields for the specified subfield
>             // Returns false if the cloning failed
>@@ -58,7 +58,7 @@
> 
>                 // Find the subfield we want to clone
>                 var re = new RegExp('^subfield' + subfield_name,'g');
>-                var subfields = $(field_start).children('div').filter( function() {
>+                var subfields = $(field_start).children('ul').children('li').filter( function() {
>                     return this.id.match(re);
>                 });
> 
>@@ -89,7 +89,7 @@
> 
>                 // Find the subfields where we will add the new values
>                 var re = new RegExp('^subfield' + subfield_name,'g');
>-                var subfields = $(field_start).children('div').filter( function() {
>+                var subfields = $(field_start).children('ul').children('li').filter( function() {
>                     return this.id.match(re);
>                 });
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 8cbd2de655..08ab8ee816 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -23,9 +23,11 @@
>             $("#toolbar").hide();
>         [% END %]
> 
>-        $('#addbibliotabs').tabs().bind('show.ui-tabs', function(e, ui) {
>+        var $tabs = $('#addbibliotabs').tabs().bind('show.ui-tabs', function(e, ui) {
>             $("#"+ui.panel.id+" input:eq(0)").focus();
>         });
>+        $( "ul.sortable_field", $tabs ).sortable();
>+        $( "ul.sortable_subfield", $tabs ).sortable();
> 
>         [% IF tab %]
>             link = $("a[href='#[% tab | html %]']");
>@@ -659,9 +661,17 @@
>                             [% IF ( BIG_LOOP.size > 1 ) %]
>                                 <h3>Section [% BIG_LOO.number | html %]</h3>
>                             [% END %]
>+                            [% previous = "" %]
>                             [% FOREACH innerloo IN BIG_LOO.innerloop %]
>                                 [% IF ( innerloo.tag ) %]
>-                                    <div class="tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>+                                [% IF innerloo.tag != previous %]
>+                                    [% IF previous != "" %]
>+                                        </ul>
>+                                    [% END %]
>+                                    [% previous = innerloo.tag %]
>+                                    <ul class="sortable_field">
>+                                [% END %]
>+                                    <li class="tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>                                         <div class="tag_title" id="div_indicator_tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>                                             [% IF advancedMARCEditor %]
>                                                 <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a>
>@@ -720,9 +730,10 @@
>                                             </span> 
>                                         </div> 
> 
>+                                        <ul class="sortable_subfield">
>                                         [% FOREACH subfield_loo IN innerloo.subfield_loop %]
>                                             
>-                                            <div class="subfield_line" style="[% subfield_loo.visibility | html %]" id="subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]">
>+                                            <li class="subfield_line" style="[% subfield_loo.visibility | html %]" id="subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]">
>                                                 [% UNLESS advancedMARCEditor %]
>                                                     [% IF ( subfield_loo.fixedfield ) %]
>                                                         <label for="tag_[% subfield_loo.tag | html %]_subfield_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" style="display:none;" class="labelsubfield">
>@@ -732,11 +743,6 @@
>                                                 [% END %]
> 
>                                                     <span class="subfieldcode">
>-                                                        [% IF ( subfield_loo.fixedfield ) %]
>-                                                            <img class="buttonUp" style="display:none;" src="[% interface | html %]/[% theme | html %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]')" alt="Move Up" title="Move Up" />
>-                                                        [% ELSE %]
>-                                                            <img class="buttonUp" src="[% interface | html %]/[% theme | html %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]')" alt="Move Up" title="Move Up" />
>-                                                        [% END %]
>                                                             <input type="text"
>                                                                 title="[% subfield_loo.marc_lib | $raw %]"
>                                                                 style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;"
>@@ -808,12 +814,14 @@
>                                                         </a>
>                                                     [% END %]
>                                                 </span>
>-                                            </div> 
>+                                            </li> 
>                                             
>                                         [% END # /FOREACH subfield_loop %]
>-                                    </div> 
>+                                        </ul> 
>+                                    </li> 
>                                 [% END %]
>                             [% END # /FOREACH BIG_LOO.innerloop %]
>+                            </ul> 
>                         </div> 
>                     [% END # /FOREACH BIG_LOOP %]
>                 </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/img/up.png b/koha-tmpl/intranet-tmpl/prog/img/up.png
>deleted file mode 100644
>index f3ede90e338da29efc9085968fe7df265fdb738a..0000000000000000000000000000000000000000
>GIT binary patch
>literal 0
>KcmV+b0RR6000031
>
>literal 362
>zcmV-w0hRuVP)<h;3K|Lk000e1NJLTq000mG000mO0{{R3C@l|D00004XF*Lt006JZ
>zHwB960000PbVXQnQ*UN;cVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUyQBX`&MX9N&
>z_xJZ=Vq&GGrLwZJadB~mhK8A$nSXzOj*gCcdV2Bk@uH%l^z`(hp`ov@ua}pXgoK1?
>zX=$sgtN8f%f`WqW?d`F#v8JY`sHmv_|NrNOQl0<+02_2tPE-H?|NsC0|NsC0|NsC0
>z|NsC0|NsC0|NsC004FpHH2?qrcu7P-RCwBAkU|3h0mOhV01!YJ0ssMoApj6S7y<wR
>zgdqSBKu`e@7G9_TKmb7m7#V~GxFG@n0R$Fcl#mo>=MV!600a<NfRCA<frm{LEC3Kd
>zU;$1+E><BXCa?fN0Abhy5I`6L00D#{01!YJ0ssMoApj6y00{ILS0r)K4FCWD07*qo
>IM6N<$f>T_H?f?J)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>index be183af7ff..c7a30621c2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>@@ -56,20 +56,20 @@ function openAuth(tagsubfieldid,authtype,source) {
> }
> 
> function ExpandField(index) {
>-    var original = document.getElementById(index); //original <div>
>-    var divs = original.getElementsByTagName('div');
>-    for(var i=0,divslen = divs.length ; i<divslen ; i++){   // foreach div
>-        if(divs[i].hasAttribute('id') == 0 ) {continue; } // div element is specific to Select2
>-        if(divs[i].getAttribute('id').match(/^subfield/)){  // if it s a subfield
>-            if (!divs[i].style.display) {
>+    var original = document.getElementById(index); //original <li>
>+    var lis = original.getElementsByTagName('li');
>+    for(var i=0,lislen = lis.length ; i<lislen ; i++){   // foreach li
>+        if(lis[i].hasAttribute('id') == 0 ) {continue; } // li element is specific to Select2
>+        if(lis[i].getAttribute('id').match(/^subfield/)){  // if it s a subfield
>+            if (!lis[i].style.display) {
>                 // first time => show all subfields
>-                divs[i].style.display = 'block';
>-            } else if (divs[i].style.display == 'none') {
>+                lis[i].style.display = 'block';
>+            } else if (lis[i].style.display == 'none') {
>                 // show
>-                divs[i].style.display = 'block';
>+                lis[i].style.display = 'block';
>             } else {
>                 // hide
>-                divs[i].style.display = 'none';
>+                lis[i].style.display = 'none';
>             }
>         }
>     }
>@@ -101,16 +101,16 @@ var Select2Utils = {
>  * @param advancedMARCEditor '0' for false, '1' for true
>  */
> function CloneField(index, hideMarc, advancedMARCEditor) {
>-    var original = document.getElementById(index); //original <div>
>+    var original = document.getElementById(index); //original <li>
>     Select2Utils.removeSelect2(original);
> 
>     var clone = original.cloneNode(true);
>     var new_key = CreateKey();
>     var new_id  = original.getAttribute('id')+new_key;
> 
>-    clone.setAttribute('id',new_id); // setting a new id for the parent div
>+    clone.setAttribute('id',new_id); // setting a new id for the parent li
> 
>-    var divs = clone.getElementsByTagName('div');
>+    var divs = Array.from(clone.getElementsByTagName('li')).concat(Array.from(clone.getElementsByTagName('div')));
> 
>     // if hide_marc, indicators are hidden fields
>     // setting a new name for the new indicator
>@@ -120,10 +120,10 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>     }
> 
>     // settings all subfields
>-    for(var i=0,divslen = divs.length ; i<divslen ; i++){      // foreach div
>+    for(var i=0,divslen = divs.length ; i<divslen ; i++){      // foreach div/li
>         if(divs[i].getAttribute("id").match(/^subfield/)){  // if it s a subfield
> 
>-            // set the attribute for the new 'div' subfields
>+            // set the attribute for the new 'li' subfields
>             divs[i].setAttribute('id',divs[i].getAttribute('id')+new_key);
> 
>             var inputs   = divs[i].getElementsByTagName('input');
>@@ -162,7 +162,7 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>                 }
>             }
>             if( $(inputs[1]).hasClass('framework_plugin') ) {
>-                var olddiv= original.getElementsByTagName('div')[i];
>+                var olddiv= original.getElementsByTagName('li')[i];
>                 var oldcontrol= olddiv.getElementsByTagName('input')[1];
>                 AddEventHandlers( oldcontrol,inputs[1],id_input );
>             }
>@@ -173,12 +173,6 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>                 labels[0].setAttribute('for',id_input);
>             }
> 
>-            if(hideMarc == '0') {
>-                // updating javascript parameters on button up
>-                var imgs = divs[i].getElementsByTagName('img');
>-                imgs[0].setAttribute('onclick',"upSubfield(\'"+divs[i].getAttribute('id')+"\');");
>-            }
>-
>             // setting its '+' and '-' buttons
>             try {
>                 var anchors = divs[i].getElementsByTagName('a');
>@@ -209,7 +203,7 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>                         // 2 possibilities :
>                         try{
>                             if( $(buttonDot).hasClass('framework_plugin') ) {
>-                                var olddiv= original.getElementsByTagName('div')[i];
>+                                var olddiv= original.getElementsByTagName('li')[i];
>                                 var oldcontrol= olddiv.getElementsByTagName('a')[0];
>                                 AddEventHandlers(oldcontrol,buttonDot,id_input);
>                             } else {
>@@ -236,10 +230,6 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>                     }
>                 }
>             }
>-            if(hideMarc == '0') {
>-                var buttonUp = divs[i].getElementsByTagName('img')[0];
>-                buttonUp.setAttribute('onclick',"upSubfield('" + divs[i].getAttribute('id') + "')");
>-            }
> 
>         } else { // it's a indicator div
>             if(divs[i].getAttribute('id').match(/^div_indicator/)){
>@@ -275,6 +265,8 @@ function CloneField(index, hideMarc, advancedMARCEditor) {
>     // insert this line on the page
>     original.parentNode.insertBefore(clone,original.nextSibling);
> 
>+    $("ul.sortable_subfield", clone).sortable();
>+
>     Select2Utils.initSelect2(original);
>     Select2Utils.initSelect2(clone);
> }
>@@ -290,7 +282,7 @@ function CloneSubfield(index, advancedMARCEditor){
>     Select2Utils.removeSelect2(original);
>     var clone = original.cloneNode(true);
>     var new_key = CreateKey();
>-    // set the attribute for the new 'div' subfields
>+    // set the attribute for the new 'li' subfields
>     var inputs     = clone.getElementsByTagName('input');
>     var selects    = clone.getElementsByTagName('select');
>     var textareas  = clone.getElementsByTagName('textarea');
>@@ -351,8 +343,6 @@ function CloneSubfield(index, advancedMARCEditor){
>     clone.setAttribute('id',new_id);
> 
>     try {
>-        var buttonUp = clone.getElementsByTagName('img')[0];
>-        buttonUp.setAttribute('onclick',"upSubfield('" + new_id + "')");
>         var anchors = clone.getElementsByTagName('a');
>         if(anchors.length){
>             for(var i = 0 ,lenanchors = anchors.length ; i < lenanchors ; i++){
>@@ -500,7 +490,7 @@ function CloneItemSubfield(original){
>     var clone = original.cloneNode(true);
>     var new_key = CreateKey();
> 
>-    // set the attribute for the new 'div' subfields
>+    // set the attribute for the new 'li' subfields
>     var inputs     = clone.getElementsByTagName('input');
>     var selects    = clone.getElementsByTagName('select');
>     var textareas  = clone.getElementsByTagName('textarea');
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 7882: 13184 | 13556 | 13789 | 14202 | 14908 | 18024 | 18025 | 18026 | 18027 | 22835 | 22836 | 23517 | 23521 | 23984 | 24227 | 24228 | 94638 | 94837 | 96344 | 96352 | 96384 | 96541 | 96542 | 96633 | 96634 | 96635