Bugzilla – Attachment 96360 Details for
Bug 24250
SIP2 returns debarred comment twice in patron screen message AF field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24250: Do not duplicate debarred comment in patron screen message AF field
Bug-24250-Do-not-duplicate-debarred-comment-in-pat.patch (text/plain), 1.39 KB, created by
Jonathan Druart
on 2019-12-17 10:33:05 UTC
(
hide
)
Description:
Bug 24250: Do not duplicate debarred comment in patron screen message AF field
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-12-17 10:33:05 UTC
Size:
1.39 KB
patch
obsolete
>From 89b90b620f9b8ede697ed69480d990208ae81eeb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 17 Dec 2019 11:31:40 +0100 >Subject: [PATCH] Bug 24250: Do not duplicate debarred comment in patron screen > message AF field > >Caused by > commit bddfed75913a2302c19c00b00a6fe86538af6f9f > Bug 19933: Remove patronflags - tricky ones > >Test plan: >1 - Setup SIP in your testing environment > https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup >2 - Set a patron to have a restriction >3 - Send a patron status request or patron information command via > the SIP cli emulator (see link above) >4 - Note the comment on the restriction is sent only once >--- > C4/SIP/ILS/Patron.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 497ec98771..0dbdbbb140 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -121,7 +121,7 @@ sub new { > if ( $patron->is_debarred and $patron->debarredcomment ) { > $ilspatron{screen_msg} .= " -- " . $patron->debarredcomment; > } >- for (qw(EXPIRED CHARGES CREDITS GNA LOST DBARRED NOTES)) { >+ for (qw(EXPIRED CHARGES CREDITS GNA LOST NOTES)) { > ($flags->{$_}) or next; > if ($_ ne 'NOTES' and $flags->{$_}->{message}) { > $ilspatron{screen_msg} .= " -- " . $flags->{$_}->{message}; # show all but internal NOTES >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24250
:
96360
|
100334
|
101074