Bugzilla – Attachment 96423 Details for
Bug 23089
Elasticsearch - cannot sort on non-text fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23089: [18.11.x] fix tests
Bug-23089-1811x-fix-tests.patch (text/plain), 2.34 KB, created by
Nick Clemens (kidclamp)
on 2019-12-18 15:02:13 UTC
(
hide
)
Description:
Bug 23089: [18.11.x] fix tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-12-18 15:02:13 UTC
Size:
2.34 KB
patch
obsolete
>From a2763cf8841039a3e63c33915c3aea0b6ca1c163 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 18 Dec 2019 15:01:53 +0000 >Subject: [PATCH] Bug 23089: [18.11.x] fix tests > >--- > t/Koha/SearchEngine/Elasticsearch.t | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/t/Koha/SearchEngine/Elasticsearch.t b/t/Koha/SearchEngine/Elasticsearch.t >index 327a0992d5..b75956771e 100644 >--- a/t/Koha/SearchEngine/Elasticsearch.t >+++ b/t/Koha/SearchEngine/Elasticsearch.t >@@ -117,7 +117,7 @@ subtest 'get_elasticsearch_mappings() tests' => sub { > > subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' => sub { > >- plan tests => 51; >+ plan tests => 52; > > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); > >@@ -332,13 +332,13 @@ subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' > is(scalar @{$docs->[0][1]->{title__sort}}, 1, 'First document title__sort field should have a single'); > is_deeply($docs->[0][1]->{title__sort}, ['Title: first record Title: first record'], 'First document title__sort field should be set correctly'); > >- is($docs->[0]->{issues}, 6, 'Issues field should be sum of the issues for each item'); >- is($docs->[0]->{issues__sort}, 6, 'Issues sort field should also be a sum of the issues'); >+ is($docs->[0][1]->{issues}, 6, 'Issues field should be sum of the issues for each item'); >+ is($docs->[0][1]->{issues__sort}, 6, 'Issues sort field should also be a sum of the issues'); > >- is(scalar @{$docs->[0]->{title_wildcard}}, 2, 'First document title_wildcard field should have two values'); >- is_deeply($docs->[0]->{title_wildcard}, ['Title:', 'first record'], 'First document title_wildcard field should be set correctly'); >+ is(scalar @{$docs->[0][1]->{title_wildcard}}, 2, 'First document title_wildcard field should have two values'); >+ is_deeply($docs->[0][1]->{title_wildcard}, ['Title:', 'first record'], 'First document title_wildcard field should be set correctly'); > >- is(scalar @{$docs->[0]->{author__suggestion}}, 2, 'First document author__suggestion field should contain two values'); >+ is(scalar @{$docs->[0][1]->{author__suggestion}}, 2, 'First document author__suggestion field should contain two values'); > is_deeply( > $docs->[0][1]->{author__suggestion}, > [ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23089
:
90451
|
93982
|
93983
|
94617
|
94618
|
94653
|
94656
|
94944
|
94945
|
94946
|
95390
| 96423