Attachment 96456 Details for Bug 24232 – Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id

[patch] Bug 24232: Fix required permissions in DELETE /biblios/:biblio_id

Bug-24232-Fix-required-permissions-in-DELETE-bibli.patch (text/plain), 1.27 KB, created by Jonathan Druart on 2019-12-18 18:34:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-18 18:34:02 UTC

Size: 1.27 KB

patch

obsolete

>From 024cfc51985b0fe5c5cc5d848871cb5f939c1958 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 17 Dec 2019 14:43:54 -0300
>Subject: [PATCH] Bug 24232: Fix required permissions in DELETE
> /biblios/:biblio_id
>
>This patch fixes the required permissions defined on the spec for the
>mentioned endpoint.
>
>To test:
>1. Apply the tests patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/api/v1/biblios.t
>=> FAIL: Tests fail due to badly defined permissions
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: Tests pass! Notice parameters: edit_catelogue didn't exist
>5. Sign off :-D
>
>Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
>
>Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> api/v1/swagger/paths/biblios.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/api/v1/swagger/paths/biblios.json b/api/v1/swagger/paths/biblios.json
>index 1ea91aca4f..b2bb58a6ce 100644
>--- a/api/v1/swagger/paths/biblios.json
>+++ b/api/v1/swagger/paths/biblios.json
>@@ -128,7 +128,7 @@
>       },
>       "x-koha-authorization": {
>         "permissions": {
>-          "parameters": "edit_catalogue"
>+          "editcatalogue": "edit_catalogue"
>         }
>       }
>     }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24232: 96388 | 96389 | 96393 | 96398 | 96434 | 96435 | 96436 | 96455 | 96456 | 96457