Attachment 96462 Details for Bug 24268 – Bug 24268: Break assignment and warn into separate actions

[patch] Bug 24268: Break assignment and warn into separate actions

Bug-24268-Break-assignment-and-warn-into-separate-.patch (text/plain), 1.15 KB, created by Liz Rea on 2019-12-18 20:22:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2019-12-18 20:22:47 UTC

Size: 1.15 KB

patch

obsolete

>From 6a7dd6e70209bebed1a78c134bffb938c6ee9e77 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 18 Dec 2019 18:53:04 +0000
>Subject: [PATCH] Bug 24268: Break assignment and warn into separate actions
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>---
> misc/cronjobs/advance_notices.pl | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index af97c4103b..bc0d54390d 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -578,7 +578,11 @@ sub send_digests {
>                     branchcode     => $branchcode,
>                     message_transport_type => $transport
>                 }
>-            ) || warn "no letter of type '$params->{letter_type}' found for borrowernumber $borrowernumber. Please see sample_notices.sql";
>+            );
>+            unless ( $letter ){
>+                warn "no letter of type '$params->{letter_type}' found for borrowernumber $borrowernumber. Please see sample_notices.sql";
>+                next;
>+            }
>             push @letters, $letter if $letter;
>         }
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24268: 96458 | 96459 | 96462 | 96463 | 96476 | 96477