Bugzilla – Attachment 9650 Details for
Bug 8128
can't seem to run new sql reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8128 - can't seem to run new sql reports
Bug-8128---cant-seem-to-run-new-sql-reports.patch (text/plain), 1.05 KB, created by
Liz Rea
on 2012-05-18 19:38:43 UTC
(
hide
)
Description:
Bug 8128 - can't seem to run new sql reports
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2012-05-18 19:38:43 UTC
Size:
1.05 KB
patch
obsolete
>From 2b5a545fa90e8c3ff44a28e7e3d858415391768b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 18 May 2012 15:01:45 -0400 >Subject: [PATCH] Bug 8128 - can't seem to run new sql reports >Content-Type: text/plain; charset="utf-8" > >Reports cannot be saved because saved_sql.cache_expiry cannot be null. >Fixed by setting default to 0 if a cache_expiry value is not >passed into the function. > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >passes t xt > >Verified original bug, patch resolves issue. >--- > C4/Reports/Guided.pm | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index 8081b32..c82e995 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -473,6 +473,7 @@ Returns id of the newly created report > > sub save_report { > my ( $borrowernumber, $sql, $name, $type, $notes, $cache_expiry, $public ) = @_; >+ $cache_expiry ||= 0; > my $dbh = C4::Context->dbh(); > $sql =~ s/(\s*\;\s*)$//; # removes trailing whitespace and /;/ > my $query = >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8128
:
9648
|
9649
| 9650 |
9698
|
9736