Attachment 96533 Details for Bug 24263 – Bug 24263: Replace borrowers.relationship with NULL when was empty string

[patch] Bug 24263: Replace borrowers.relationship with NULL when was empty string

Bug-24263-Replace-borrowersrelationship-with-NULL-.patch (text/plain), 1.71 KB, created by Martin Renvoize (ashimema) on 2019-12-20 17:44:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-12-20 17:44:01 UTC

Size: 1.71 KB

patch

obsolete

>From bebdb0e8c6f3e99c39344da79b22147785a6200b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 18 Dec 2019 14:04:58 +0100
>Subject: [PATCH] Bug 24263: Replace borrowers.relationship with NULL when was
> empty string
>
>When you create a new patron, its relationship field is populated with
>an empty string when we are expecting NULL.
>
>Otherwise the about page will display a warning about a missing/wrong
>relationship in data (that is not in the syspref)
>
>Test plan:
>0/ Do not apply the patches from this bug report
>1/ Create a new patron (child)
>2/ Notice that relationship column in DB is set to an empty string
>3/ Go to the about page, notice the invalid warning about relationship
>values not in the syspref
>4/ Apply DB changes and tests
>5/ Execute the update DB entry
>=> The value in DB is now NULL when was ""
>6/ Execute the tests
>=> It fails
>7/ Apply the last patch
>8/ Add and edit a patron (child)
>=> relationship is set to NULL in DB
>9/ Execute the tests
>=> They pass!
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Patron.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 2de2965e7f..809cfab0c7 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -199,6 +199,10 @@ sub store {
>             $self->surname( uc($self->surname) )
>                 if C4::Context->preference("uppercasesurnames");
> 
>+            $self->relationship(undef) # We do not want to store an empty string in this field
>+              if defined $self->relationship
>+                     and $self->relationship eq "";
>+
>             unless ( $self->in_storage ) {    #AddMember
> 
>                 # Generate a valid userid/login if needed
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24263: 96418 | 96419 | 96420 | 96531 | 96532 | 96533 | 96989 | 96990 | 96991 | 96992