Attachment 96620 Details for Bug 24282 – Bug 24282: SCSS conversion broke style in search results item status

[patch] Bug 24282: SCSS conversion broke style in search results item status

Bug-24282-SCSS-conversion-broke-style-in-search-re.patch (text/plain), 2.30 KB, created by Lucas Gass (lukeg) on 2019-12-23 23:07:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2019-12-23 23:07:46 UTC

Size: 2.30 KB

patch

obsolete

>From 77601e30842e6f4d04f19dce57071087ce97897c Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Fri, 20 Dec 2019 08:40:37 +0100
>Subject: [PATCH] Bug 24282: SCSS conversion broke style in search results item
> status
>
>Before SCSS conversion, there was a style for search results item status :
>  #searchresults span.status {
>Conversion to SCSS added ul :
>  #searchresults ul span.status {
>Now style does not apply anymore.
>You can see that items on loan are not red anymore.
>
>To test, apply the patch and regenerate your CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>Clear your browser cache if necessary.
>
>All rules using #searchresults in 17.11 :
>    font-size : 90%;
>    list-style: url(../img/item-bullet.gif);
>    padding : .2em 0;
>        clear : left;
>}
>
>    clear : left;
>    color : #900;
>    display : block;
>}
>
>    clear : left;
>    display : block;
>}
>
>    display : block;
>}
>
>    float : left;
>    margin : 3px 5px 3px -5px;
>}
>
>    vertical-align : top;
>}
>
>Apply patch update intranet CSS file and check you see the same rules.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/css/src/staff-global.scss   | 28 +++++++++++-----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 950da22f35..c2d969099d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -1972,24 +1972,24 @@ li {
>                 margin: 3px 5px 3px -5px;
>             }
>         }
>+    }
> 
>-        span {
>-            &.status {
>-                clear: left;
>-                color: #900;
>-                display: block;
>-            }
>+    span {
>+        &.status {
>+            clear: left;
>+            color: #900;
>+            display: block;
>+        }
> 
>-            &.unavailable {
>-                clear: left;
>-                display: block;
>-            }
>+        &.unavailable {
>+            clear: left;
>+            display: block;
>         }
>+    }
> 
>-        table {
>-            td {
>-                vertical-align: top;
>-            }
>+    table {
>+        td {
>+            vertical-align: top;
>         }
>     }
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24282: 96505 | 96620 | 96672