Bugzilla – Attachment 96634 Details for
Bug 7882
Add ability to move and reorder fields and subfields in MARC editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7882: (follow-up) Update sorting interaction
Bug-7882-follow-up-Update-sorting-interaction.patch (text/plain), 3.09 KB, created by
Jonathan Druart
on 2019-12-26 11:34:00 UTC
(
hide
)
Description:
Bug 7882: (follow-up) Update sorting interaction
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-12-26 11:34:00 UTC
Size:
3.09 KB
patch
obsolete
>From d9084cbc667f6bf93ac2e5abb0d4eafc8e85776c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 16 Dec 2019 19:06:57 +0000 >Subject: [PATCH] Bug 7882: (follow-up) Update sorting interaction > >This follow-up modifies the CSS for the sortable fields so that a >different icon is used. Elsewhere in Koha (stock rotation stage sorting) >we use the "bars" icon to indicate a sortable element. I think it would >be good to continue to use this. The cursor is now styled as a "Move" >cursor. > >The configuration of the sortable function in the script has been >updated in two ways: 1. The movement of the element is constrained along >the y-axis, and 2. The movement of the element is contstrained to the >container within which it can be moved (for the tag, the tab, and for >the subfield, the tag). > >To test, apply the patch and edit a MARC record in the basic cataloging >editor. > >Confirm that the new icon is used, and that the "Move" cursor shows when >you hover over the icon. > >Confirm that a tag can be dragged up and down within the constraints of >the visible section. A subfield should be only movable within its parent >tag. > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 9 ++++++--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 10 ++++++++-- > 2 files changed, 14 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css >index 28cf3414c2..99ade19239 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css >@@ -26,16 +26,19 @@ ul li.tag, ul li.tag li.subfield_line { > padding-left: 30px; > } > >-ul li.tag:before, ul li.tag li.subfield_line:before { >+ul li.tag::before, >+ul li.tag li.subfield_line::before { >+ color: #999; >+ cursor: move; > position: absolute; > font-family: 'FontAwesome'; > font-size: .8em; > top: 0; > left: 10px; >- content: "\f047"; >+ content: "\f0c9"; > } > >-ul li.tag:before { >+ul li.tag::before { > padding-top: 1.7em; > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 08ab8ee816..473556a485 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -26,8 +26,14 @@ > var $tabs = $('#addbibliotabs').tabs().bind('show.ui-tabs', function(e, ui) { > $("#"+ui.panel.id+" input:eq(0)").focus(); > }); >- $( "ul.sortable_field", $tabs ).sortable(); >- $( "ul.sortable_subfield", $tabs ).sortable(); >+ $( "ul.sortable_field", $tabs ).sortable({ >+ axis: "y", >+ containment: $("#addbibliotabs") >+ }); >+ $( "ul.sortable_subfield", $tabs ).sortable({ >+ axis: "y", >+ containment: "parent" >+ }); > > [% IF tab %] > link = $("a[href='#[% tab | html %]']"); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7882
:
13184
|
13556
|
13789
|
14202
|
14908
|
18024
|
18025
|
18026
|
18027
|
22835
|
22836
|
23517
|
23521
|
23984
|
24227
|
24228
|
94638
|
94837
|
96344
|
96352
|
96384
|
96541
|
96542
|
96633
| 96634 |
96635