Attachment 96635 Details for Bug 7882 – Bug 7882: (follow-up) Only show sortable icon for sortable tags

[patch] Bug 7882: (follow-up) Only show sortable icon for sortable tags

Bug-7882-follow-up-Only-show-sortable-icon-for-sor.patch (text/plain), 3.46 KB, created by Jonathan Druart on 2019-12-26 11:34:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-26 11:34:05 UTC

Size: 3.46 KB

patch

obsolete

>From 7e2ccded534bdcae26ae51d7cdf7fcdddd4804e2 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 17 Dec 2019 15:19:56 +0000
>Subject: [PATCH] Bug 7882: (follow-up) Only show sortable icon for sortable
> tags
>
>Only tags which can be repeated can be sorted, so the "bars" icon should
>not display by these tags.
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/css/addbiblio.css              | 13 +++++++++++--
> .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt  | 12 ++++++++++--
> 2 files changed, 21 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>index 99ade19239..ff79659a96 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css
>@@ -15,7 +15,7 @@ div#toolbar {
>     margin: .3em 0;
> }
> 
>-ul.sortable_field, ul.sortable_subfield {
>+.ui-tabs-panel ul {
>     margin-bottom: 0;
>     padding-left: 0;
> }
>@@ -26,7 +26,16 @@ ul li.tag, ul li.tag li.subfield_line {
>     padding-left: 30px;
> }
> 
>-ul li.tag::before,
>+ul li.tag::before {
>+    position: absolute;
>+    font-size: .8em;
>+    top: 0;
>+    left: 10px;
>+    content: " ";
>+}
>+
>+
>+ul li.tag.sortable_tag::before,
> ul li.tag li.subfield_line::before {
>     color: #999;
>     cursor: move;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 473556a485..1d0b55e560 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -675,9 +675,17 @@
>                                         </ul>
>                                     [% END %]
>                                     [% previous = innerloo.tag %]
>-                                    <ul class="sortable_field">
>+                                    [% IF ( innerloo.repeatable ) %]
>+                                        <ul class="sortable_field">
>+                                    [% ELSE %]
>+                                        <ul>
>+                                    [% END %]
>                                 [% END %]
>-                                    <li class="tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>+                                    [% IF ( innerloo.repeatable ) %]
>+                                        <li class="tag sortable_tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>+                                    [% ELSE %]
>+                                        <li class="tag clearfix" id="tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>+                                    [% END %]
>                                         <div class="tag_title" id="div_indicator_tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]">
>                                             [% IF advancedMARCEditor %]
>                                                 <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 7882: 13184 | 13556 | 13789 | 14202 | 14908 | 18024 | 18025 | 18026 | 18027 | 22835 | 22836 | 23517 | 23521 | 23984 | 24227 | 24228 | 94638 | 94837 | 96344 | 96352 | 96384 | 96541 | 96542 | 96633 | 96634 | 96635