Attachment 96650 Details for Bug 24313 – Bug 24313: Always display XSLT errors in logs

[patch] Bug 24313: Always display XSLT errors in logs

Bug-24313-Always-display-XSLT-errors-in-logs.patch (text/plain), 1.40 KB, created by Jonathan Druart on 2019-12-27 13:57:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-12-27 13:57:04 UTC

Size: 1.40 KB

patch

obsolete

>From ef731453f1db59204f30fdf42b7d4f5f99ea08bf Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 27 Dec 2019 14:55:36 +0100
>Subject: [PATCH] Bug 24313: Always display XSLT errors in logs
>
>From
>  commit 295ae33800a322facfdf56795f4c02b2fd53432b
>  Bug 20272: Replace error numbers by codes in XSLT_Handler
>
>"""
>    Make XSLT_Handler a little bit less noisy by defaulting print_warns to
>    false unless $ENV{DEBUG} is set. (See also bug 19018).
>"""
>
>I think we should warn the errors in the logs. They are not debug messages here, we should not rely on DEBUG.
>If too noisy we should fix the original issues, not hide all the errors (which make the XSLT debugging super hard)
>
>Test plan:
>Break a XSLT, reload the page and confirm that there are useful errors in the Koha log file
>---
> Koha/XSLT_Handler.pm | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/Koha/XSLT_Handler.pm b/Koha/XSLT_Handler.pm
>index 0682c3ca20..5b0726fddf 100644
>--- a/Koha/XSLT_Handler.pm
>+++ b/Koha/XSLT_Handler.pm
>@@ -264,9 +264,7 @@ sub _init {
> 
>     $self->_set_error;
>     $self->{xslt_hash} = {};
>-    $self->{print_warns} = exists $self->{print_warns}
>-        ? $self->{print_warns}
>-        : $ENV{DEBUG} // 0;
>+    $self->{print_warns} = 1 unless exists $self->{print_warns};
>     $self->{do_not_return_source} = 0
>       unless exists $self->{do_not_return_source};
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24313: 96650 | 96654 | 97146