Attachment 96661 Details for Bug 23893 – Bug 23893: (QA follow-up) Explicit date format

[patch] Bug 23893: (QA follow-up) Explicit date format

Bug-23893-QA-follow-up-Explicit-date-format.patch (text/plain), 1.38 KB, created by Tomás Cohen Arazi (tcohen) on 2019-12-27 15:22:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-12-27 15:22:21 UTC

Size: 1.38 KB

patch

obsolete

>From fb2776b6fc80107fbd37a91b333507b3c9e409d7 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 27 Dec 2019 12:15:39 -0300
>Subject: [PATCH] Bug 23893: (QA follow-up) Explicit date format
>
>This patch makes the input date format explicit. It also adds a missing
>POD.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Patron.pm | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 4038ddf94e..e57ea64b7f 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -1566,17 +1566,26 @@ sub to_api {
>     return $json_patron;
> }
> 
>+=head3 attributes_from_api
>+
>+    my $attrs = $patron->attributes_from_api( $attrs );
>+
>+Overloaded method that implement specific data transformations after
>+calling the original Koha::Object->attributes_from_api method.
>+
>+=cut
>+
> sub attributes_from_api {
>     my ( $self, $attrs ) = @_;
> 
>     $attrs = $self->SUPER::attributes_from_api( $attrs );
> 
>     if ( exists $attrs->{lastseen} ) {
>-        $attrs->{lastseen} = dt_from_string($attrs->{lastseen});
>+        $attrs->{lastseen} = dt_from_string($attrs->{lastseen}, 'rfc3339');
>     }
> 
>     if ( exists $attrs->{updated_on} ) {
>-        $attrs->{updated_on} = dt_from_string($attrs->{updated_on});
>+        $attrs->{updated_on} = dt_from_string($attrs->{updated_on}, 'rfc3339');
>     }
> 
>     return $attrs;
>-- 
>2.24.1

Actions: View | Diff | Splinter Review

Attachments on bug 23893: 95276 | 95277 | 95278 | 95311 | 95312 | 95313 | 95314 | 95315 | 96126 | 96127 | 96128 | 96129 | 96130 | 96652 | 96655 | 96656 | 96657 | 96658 | 96659 | 96660 | 96661 | 96662 | 96665 | 96666 | 96920 | 96921 | 96922 | 96923 | 96924 | 96925 | 96926 | 96927 | 96928 | 96929 | 96930 | 96931 | 96932 | 96933 | 96934 | 96935 | 96936 | 96937 | 97391