Bugzilla – Attachment 96681 Details for
Bug 24175
Cannot cancel holds - wrong parameter passed for itemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24175: [19.05.x] Use itemnumber when searching for holds in SIP drop_hold
Bug-24175-1905x-Use-itemnumber-when-searching-for-.patch (text/plain), 1.47 KB, created by
Nick Clemens (kidclamp)
on 2019-12-30 12:12:56 UTC
(
hide
)
Description:
Bug 24175: [19.05.x] Use itemnumber when searching for holds in SIP drop_hold
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-12-30 12:12:56 UTC
Size:
1.47 KB
patch
obsolete
>From 5d0977c4b1be49109780984ce48342383923624f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 4 Dec 2019 18:50:41 +0000 >Subject: [PATCH] Bug 24175: [19.05.x] Use itemnumber when searching for holds > in SIP drop_hold >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1 - place a hold for a patron >2 - Get SIP running > https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup >3 - edit the sip_cli_emulator.pl for hold_mode from '+' to '-' >4 - Attempt to cancel hold >5 - It fails >6 - Apply patch >7 - Try again >8 - It succeeds > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/SIP/ILS/Transaction/Hold.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Hold.pm b/C4/SIP/ILS/Transaction/Hold.pm >index 63e1a06dbb..bd13f304d8 100644 >--- a/C4/SIP/ILS/Transaction/Hold.pm >+++ b/C4/SIP/ILS/Transaction/Hold.pm >@@ -87,11 +87,10 @@ sub drop_hold { > return $self; > } > my $item = Koha::Items->find({ barcode => $self->{item}->id }); >- > my $holds = Koha::Holds->search( > { > biblionumber => $item->biblionumber, >- itemnumber => $self->{item}->id, >+ itemnumber => $item->itemnumber, > borrowernumber => $patron->borrowernumber > } > ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24175
:
95999
|
96000
|
96372
|
96375
|
96376
|
96377
|
96378
|
96527
|
96528
|
96529
|
96530
|
96534
|
96535
|
96536
|
96537
|
96680
| 96681