Attachment 96764 Details for Bug 9156 – Bug 9156: Clarify order in the syspref

[patch] Bug 9156: Clarify order in the syspref

Bug-9156-Clarify-order-in-the-syspref.patch (text/plain), 2.43 KB, created by Nick Clemens (kidclamp) on 2020-01-02 18:06:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-01-02 18:06:39 UTC

Size: 2.43 KB

patch

obsolete

>From 9e96fcfac92f654c08262f68a93f0a3fd6f5800c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 2 Jan 2020 18:06:20 +0000
>Subject: [PATCH] Bug 9156: Clarify order in the syspref
>
>---
> C4/Reserves.pm | 4 ++--
> .../intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 7a3785724a..c508b44294 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -1195,8 +1195,8 @@ sub IsAvailableForItemLevelRequest {
> # FIXME - a lot of places in the code do this
> # or something similar - need to be
> # consolidated
>- my $itemtype = $item->effective_itemtype;
>- my $notforloan_per_itemtype = Koha::ItemTypes->find($itemtype)->notforloan;
>+ my $itemtype = Koha::ItemTypes->find( $item->effective_itemtype );
>+ my $notforloan_per_itemtype = defined $itemtype ? $itemtype->notforloan : 0;
> 
> return 0 if
> $notforloan_per_itemtype ||
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>index dbfd788c66..456f732fa1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>@@ -74,7 +74,7 @@ Cataloging:
> -
> - Map the MARC subfield
> - pref: itemcallnumber
>- - "to an item's callnumber. (This can contain multiple subfields to look in; for instance <code>082ab</code> would look in 082 subfields a and b.) Examples (for MARC21 records): Dewey: <code>082ab</code> or <code>092ab</code>; LOC: <code>050ab</code> or <code>090ab</code>; from the item record: <code>852hi</code>"
>+ - "to an item's callnumber. (This can contain multiple subfields to look in; for instance <code>082ab</code> would look in 082 subfields a and b.)Note: The order of the subfields in the record will be preserved. Examples (for MARC21 records): Dewey: <code>082ab</code> or <code>092ab</code>; LOC: <code>050ab</code> or <code>090ab</code>; from the item record: <code>852hi</code>"
> -
> - Display MARC subfield
> - pref: AlternateHoldingsField
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 9156: 13711 | 13712 | 95580 | 96486 | 96499 | 96764 | 96766 | 96767 | 96792 | 97190 | 97191 | 97192