Attachment 96802 Details for Bug 24337 – Bug 24337: Checkout note cannot be marked seen if more than 20 exist

[patch] Bug 24337: Checkout note cannot be marked seen if more than 20 exist

Bug-24337-Checkout-note-cannot-be-marked-seen-if-m.patch (text/plain), 1.65 KB, created by ByWater Sandboxes on 2020-01-03 20:32:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2020-01-03 20:32:30 UTC

Size: 1.65 KB

patch

obsolete

>From 738b4b2c6d5b33e65b81aa79750e7c957553ad6d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 3 Jan 2020 20:02:26 +0000
>Subject: [PATCH] Bug 24337: Checkout note cannot be marked seen if more than
> 20 exist
>
>This patch modifies the event handler on the individual "Mark seen" /
>"Mark unseen" buttons in the table of checkout notes. For an event to be
>successfully attached to a hidden element it must be given a context.
>
>To test you should have multiple checkout notes to work with, both seen
>and unseen. Apply the patch and go to "Checkout notes pending" from the
>staff client home page.
>
> - Navigate to the second "page" of data in the DataTable.
> - Test the functionality of the "Mark seen" and "Mark unseen" buttons.
>   They should work correctly.
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
>index 08d262d15c..360a46ff08 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
>@@ -166,7 +166,7 @@
>                 }
>             });
> 
>-            $("button.seen, button.notseen").click(function(event){
>+            $("#notestable").on("click", "button.seen, button.notseen", function(event){
>                 event.preventDefault(); // prevent form submission
>                 var $action = $(this).attr("name");
>                 var $issue_id = $(this).data('issue_id');
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24337: 96801 | 96802 | 97173