Bugzilla – Attachment 96873 Details for
Bug 24361
Fix warnings (or failing tests) from bug 24217
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24361: Fix warning in C4::Record line 435
Bug-24361-Fix-warning-in-C4Record-line-435.patch (text/plain), 1.74 KB, created by
Jonathan Druart
on 2020-01-07 11:27:48 UTC
(
hide
)
Description:
Bug 24361: Fix warning in C4::Record line 435
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-07 11:27:48 UTC
Size:
1.74 KB
patch
obsolete
>From 43fb0182d490b6e29c2316ce68ee79a7f4c3e70e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Jan 2020 12:26:01 +0100 >Subject: [PATCH] Bug 24361: Fix warning in C4::Record line 435 > >Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435 > >Caught by a failing test: > # Failed test 'Export csv with wrong marcxml should raise a warning' > # at t/db_dependent/Exporter/Record.t line 113. > # found warning: problem with :721 : :1: parser error : Start tag expected, '<' not found > # found warning: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435. > # expected to find warning: (?^u:.*Start tag expected.*) > >Test plan: >Make sure the tests pass now >--- > C4/Record.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Record.pm b/C4/Record.pm >index f54e368449..e53d155f86 100644 >--- a/C4/Record.pm >+++ b/C4/Record.pm >@@ -427,12 +427,12 @@ sub marc2csv { > for my $itemnumber ( @$itemnumbers) { > my $item = Koha::Items->find( $itemnumber ); > my $biblionumber = $item->biblio->biblionumber; >- $output .= marcrecord2csv( $biblionumber, $id, $firstpass, $csv, $fieldprocessing, [$itemnumber] ); >+ $output .= marcrecord2csv( $biblionumber, $id, $firstpass, $csv, $fieldprocessing, [$itemnumber] ) // ''; > $firstpass = 0; > } > } else { > foreach my $biblio (@$biblios) { >- $output .= marcrecord2csv( $biblio, $id, $firstpass, $csv, $fieldprocessing ); >+ $output .= marcrecord2csv( $biblio, $id, $firstpass, $csv, $fieldprocessing ) // ''; > $firstpass = 0; > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24361
: 96873 |
96892
|
96969
|
97315
|
97991
|
98796