Bugzilla – Attachment 96898 Details for
Bug 21684
Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21684: Fix Hold.t
Bug-21684-Fix-Holdt.patch (text/plain), 1.51 KB, created by
Jonathan Druart
on 2020-01-07 15:07:30 UTC
(
hide
)
Description:
Bug 21684: Fix Hold.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-07 15:07:30 UTC
Size:
1.51 KB
patch
obsolete
>From f8f56fade5feb52bc4e9591118891aaee19beb1b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 7 Jan 2020 16:06:38 +0100 >Subject: [PATCH] Bug 21684: Fix Hold.t > >--- > t/db_dependent/Hold.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Hold.t b/t/db_dependent/Hold.t >index 2ba6f7bafb..674f58ae3e 100755 >--- a/t/db_dependent/Hold.t >+++ b/t/db_dependent/Hold.t >@@ -150,7 +150,7 @@ subtest "delete() tests" => sub { > > my $hold_object = Koha::Holds->find( $hold->{ reserve_id } ); > my $deleted = $hold_object->delete; >- is( $deleted, 1, 'Koha::Hold->delete should return 1 if the hold has been correctly deleted' ); >+ is( ref($deleted), 'Koha::Hold', 'Koha::Hold->delete should return the Koha::Hold object if the hold has been correctly deleted' ); > is( Koha::Holds->search({ reserve_id => $hold->{ reserve_id } })->count, 0, > "Koha::Hold->delete should have deleted the hold" ); > >@@ -165,7 +165,7 @@ subtest "delete() tests" => sub { > > $hold_object = Koha::Holds->find( $hold->{ reserve_id } ); > $deleted = $hold_object->delete; >- is( $deleted, 1, 'Koha::Hold->delete should return 1 if the hold has been correctly deleted' ); >+ is( ref($deleted), 'Koha::Hold', 'Koha::Hold->delete should return a Koha::Hold object if the hold has been correctly deleted' ); > is( Koha::Holds->search({ reserve_id => $hold->{ reserve_id } })->count, 0, > "Koha::Hold->delete should have deleted the hold" ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21684
:
81317
|
81318
|
81319
|
90937
|
96218
|
96254
|
96270
|
96271
|
96272
|
96429
|
96430
|
96431
|
96872
|
96888
|
96895
| 96898