Attachment 97157 Details for Bug 24367 – Bug 24367: Resolve warn Argument available is not numeric in delete

[patch] Bug 24367: Resolve warn Argument available is not numeric in delete

Bug-24367-Resolve-warn-Argument-available-is-not-n.patch (text/plain), 1.04 KB, created by Marcel de Rooy on 2020-01-10 08:17:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-01-10 08:17:29 UTC

Size: 1.04 KB

patch

obsolete

>From 19d261336d2c4f1f3f1adbf5fc1f1ef232dbaf96 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 10 Jan 2020 07:54:33 +0000
>Subject: [PATCH] Bug 24367: Resolve warn Argument available is not numeric in
> delete
>Content-Type: text/plain; charset=utf-8
>
>Argument "available" isn't numeric in delete at /usr/share/koha/C4/Search.pm line 1480.
>The construction delete array[string] simply does not work.
>---
> C4/Search.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index 77bda3064f..c1a21e9ce2 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -1477,7 +1477,7 @@ sub buildQuery {
>         if ( @limits ) {
>             if ( grep { /^available$/ } @limits ) {
>                 $q .= q| and ( (allrecords,AlwaysMatches='') and (not-onloan-count,st-numeric >= 1) and (lost,st-numeric=0) )|;
>-                delete $limits['available'];
>+                @limits = grep {!/^available$/} @limits;
>             }
>             $q .= ' and '.join(' and ', @limits) if @limits;
>         }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24367: 96911 | 97096 | 97097 | 97157 | 97158 | 97159 | 97163 | 99113