Bugzilla – Attachment 97331 Details for
Bug 18731
Add routes for acquisition orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18731: Overload K::A::Fund->to_api to avoid conflict
Bug-18731-Overload-KAFund-toapi-to-avoid-conflict.patch (text/plain), 3.23 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-01-13 18:46:45 UTC
(
hide
)
Description:
Bug 18731: Overload K::A::Fund->to_api to avoid conflict
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-01-13 18:46:45 UTC
Size:
3.23 KB
patch
obsolete
>From aeb4f1e36e901ddb5a5490811f03fc2477a1d014 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 13 Jan 2020 15:44:33 -0300 >Subject: [PATCH] Bug 18731: Overload K::A::Fund->to_api to avoid conflict > >This patch overloads the to_api methods on the Fund class, so >conflicting (on mapping) attribute names are not a problem. > >To test: >1. Apply this patch >2. Run: > $ kshell > k$ prove t/db_dependent/Koha/Acquisition/Fund.t \ > t/db_dependent/Koha/REST/Plugin/Objects.t >=> SUCCESS: Tests pass! >3. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Acquisition/Fund.pm | 23 ++++++++++++++ > t/db_dependent/Koha/Acquisition/Fund.t | 44 ++++++++++++++++++++++++++ > 2 files changed, 67 insertions(+) > create mode 100644 t/db_dependent/Koha/Acquisition/Fund.t > >diff --git a/Koha/Acquisition/Fund.pm b/Koha/Acquisition/Fund.pm >index 484b19fd09..c135fa1c7e 100644 >--- a/Koha/Acquisition/Fund.pm >+++ b/Koha/Acquisition/Fund.pm >@@ -29,6 +29,29 @@ Koha::Acquisition::Fund object class > > =head2 Class methods > >+=head3 to_api >+ >+ my $json = $fund->to_api; >+ >+Overloaded method that returns a JSON representation of the Koha::Acquisition::Fund object, >+suitable for API output. >+ >+=cut >+ >+sub to_api { >+ my ( $self, $args ) = @_; >+ >+ # Preserve conflicting attribute names >+ my $budget_id = $self->budget_id; >+ my $budget_period_id = $self->budget_period_id; >+ >+ my $json_fund = $self->SUPER::to_api($args); >+ $json_fund->{fund_id} = $budget_id; >+ $json_fund->{budget_id} = $budget_period_id; >+ >+ return $json_fund; >+} >+ > =head3 to_api_mapping > > This method returns the mapping for representing a Koha::Acquisition::Fund object >diff --git a/t/db_dependent/Koha/Acquisition/Fund.t b/t/db_dependent/Koha/Acquisition/Fund.t >new file mode 100644 >index 0000000000..98ab1dcbf9 >--- /dev/null >+++ b/t/db_dependent/Koha/Acquisition/Fund.t >@@ -0,0 +1,44 @@ >+#!/usr/bin/perl >+ >+# Copyright 2019 Koha Development team >+# >+# This file is part of Koha >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 1; >+ >+use t::lib::TestBuilder; >+ >+use Koha::Database; >+ >+my $schema = Koha::Database->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+subtest 'to_api() tests' => sub { >+ >+ plan tests => 2; >+ >+ $schema->storage->txn_begin; >+ >+ my $fund = $builder->build_object({ class => 'Koha::Acquisition::Funds' }); >+ my $fund_api = $fund->to_api(); >+ >+ is( $fund->budget_id, $fund_api->{fund_id}, 'Mapping is correct for budget_id' ); >+ is( $fund->budget_period_id, $fund_api->{budget_id}, 'Mapping is correct for budget_period_id' ); >+ >+ $schema->storage->txn_rollback; >+}; >-- >2.24.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18731
:
69184
|
69185
|
69309
|
69310
|
69544
|
73959
|
73960
|
78435
|
78436
|
84133
|
84134
|
95054
|
95055
|
95056
|
96853
|
96854
|
96855
|
96856
|
96857
|
96858
|
96916
|
96917
|
96918
|
96938
|
96961
|
96962
|
96963
|
96964
|
96965
|
96966
|
97107
|
97108
|
97109
|
97110
|
97111
|
97112
|
97113
| 97331