Bugzilla – Attachment 97352 Details for
Bug 24350
Can't place holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24350: ->pickup_locations returns unblessed objects
Bug-24350--pickuplocations-returns-unblessed-objec.patch (text/plain), 7.64 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-01-14 13:30:07 UTC
(
hide
)
Description:
Bug 24350: ->pickup_locations returns unblessed objects
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-01-14 13:30:07 UTC
Size:
7.64 KB
patch
obsolete
>From 375269bed73bb494fc5fc8d2d739c709f3a6fce1 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 14 Jan 2020 10:29:47 -0300 >Subject: [PATCH] Bug 24350: ->pickup_locations returns unblessed objects > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Koha/Libraries.t | 34 ++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > >diff --git a/t/db_dependent/Koha/Libraries.t b/t/db_dependent/Koha/Libraries.t >index 45da1ae0ae..f8345b2a5e 100644 >--- a/t/db_dependent/Koha/Libraries.t >+++ b/t/db_dependent/Koha/Libraries.t >@@ -192,7 +192,7 @@ subtest 'pickup_locations' => sub { > my $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > my $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -201,7 +201,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item1, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -221,7 +221,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -230,7 +230,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item2, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -240,7 +240,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -249,7 +249,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item1, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -278,7 +278,7 @@ subtest 'pickup_locations' => sub { > my $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > my $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -287,7 +287,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item1, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -302,7 +302,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -319,7 +319,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -328,7 +328,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item1, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -355,7 +355,7 @@ subtest 'pickup_locations' => sub { > my $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > my $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -364,7 +364,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item1, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -384,7 +384,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -393,7 +393,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item3, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -403,7 +403,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ biblio => $biblio->biblionumber, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >@@ -412,7 +412,7 @@ subtest 'pickup_locations' => sub { > $pickup = Koha::Libraries->pickup_locations({ item => $item1, patron => $patron1 }); > $found = 0; > foreach my $lib (@{$pickup}) { >- if ($lib->branchcode eq $limit->toBranch) { >+ if ($lib->{branchcode} eq $limit->toBranch) { > $found = 1; > } > } >-- >2.25.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24350
:
96860
|
96912
|
96913
|
97231
|
97258
|
97259
|
97260
|
97261
| 97352