Bugzilla – Attachment 97375 Details for
Bug 24185
'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24185: Make holds page faster - improved "if"
Bug-24185-Make-holds-page-faster---improved-if.patch (text/plain), 1.07 KB, created by
Andrii Nugged
on 2020-01-15 07:22:41 UTC
(
hide
)
Description:
Bug 24185: Make holds page faster - improved "if"
Filename:
MIME Type:
Creator:
Andrii Nugged
Created:
2020-01-15 07:22:41 UTC
Size:
1.07 KB
patch
obsolete
>From 2a9e3cf5bc8b331692ac9445cebbc7417ef0cfd3 Mon Sep 17 00:00:00 2001 >From: Andrew Nugged <nugged@gmail.com> >Date: Thu, 19 Dec 2019 18:16:33 +0200 >Subject: [PATCH] Bug 24185: Make holds page faster - improved "if" > >`$can_item_be_reserved eq 'OK'` moved in `&&` before `IsAvailableForItemLevelRequest` >to cut away with static known values before calling to more resource consuming subroutine. >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index c7376c2857..8db78a1e33 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -556,8 +556,8 @@ foreach my $biblionumber (@biblionumbers) { > if ( > !$item->{cantreserve} > && !$exceeded_maxreserves >- && IsAvailableForItemLevelRequest($item_object, $patron) > && $can_item_be_reserved eq 'OK' >+ && IsAvailableForItemLevelRequest($item_object, $patron) > ) > { > $item->{available} = 1; >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24185
:
96079
|
96080
|
96151
|
96354
|
96460
|
96461
|
96464
|
96491
|
96492
|
96493
|
96500
|
97375
|
97376
|
97377
|
97378
|
101355
|
101356
|
101357
|
101358
|
101607
|
101608
|
101609
|
101611
|
101613
|
101614
|
101615
|
101616