Bugzilla – Attachment 97388 Details for
Bug 20567
"Holds per record (count)" limit is not enforced after item is captured for hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20567: Add tests
Bug-20567-Add-tests.patch (text/plain), 1.35 KB, created by
Kyle M Hall (khall)
on 2020-01-15 11:44:30 UTC
(
hide
)
Description:
Bug 20567: Add tests
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-01-15 11:44:30 UTC
Size:
1.35 KB
patch
obsolete
>From a90673352c798a37f4bbb695fb9cd949d854856e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 Jan 2020 10:33:03 +0100 >Subject: [PATCH] Bug 20567: Add tests > >Signed-off-by: Hans Palsson <hans.palsson@hkr.se> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Reserves/MultiplePerRecord.t | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Reserves/MultiplePerRecord.t b/t/db_dependent/Reserves/MultiplePerRecord.t >index 7f639ce459..80c1c3ecd1 100755 >--- a/t/db_dependent/Reserves/MultiplePerRecord.t >+++ b/t/db_dependent/Reserves/MultiplePerRecord.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 38; >+use Test::More tests => 39; > use t::lib::TestBuilder; > use t::lib::Mocks; > >@@ -289,5 +289,8 @@ ok( $hold_id, 'Second hold was placed' ); > $can = CanBookBeReserved($patron->{borrowernumber}, $biblio->{biblionumber}); > is( $can->{status}, 'tooManyHoldsForThisRecord', 'Third hold exceeds limit of holds per record' ); > >-$schema->storage->txn_rollback; >+Koha::Holds->find($hold_id)->found("W")->store; >+$can = CanBookBeReserved($patron->{borrowernumber}, $biblio->{biblionumber}); >+is( $can->{status}, 'tooManyHoldsForThisRecord', 'Third hold exceeds limit of holds per record' ); > >+$schema->storage->txn_rollback; >-- >2.21.1 (Apple Git-122.3)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20567
:
74042
|
97336
|
97337
|
97386
|
97387
| 97388 |
97389