Bugzilla – Attachment 97395 Details for
Bug 19014
Patrons should not get an 'on_reserve' notification if the due date is far into the future
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19014: Unit tests
Bug-19014-Unit-tests.patch (text/plain), 1.87 KB, created by
ByWater Sandboxes
on 2020-01-15 14:50:16 UTC
(
hide
)
Description:
Bug 19014: Unit tests
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2020-01-15 14:50:16 UTC
Size:
1.87 KB
patch
obsolete
>From 990517535b2e5df2ab10f603238ce1503c509230 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 30 Dec 2019 19:27:26 +0000 >Subject: [PATCH] Bug 19014: Unit tests > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > t/db_dependent/Circulation.t | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index c0e2dacece..d818cb9ac5 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -277,7 +277,7 @@ $dbh->do( > > my ( $reused_itemnumber_1, $reused_itemnumber_2 ); > subtest "CanBookBeRenewed tests" => sub { >- plan tests => 71; >+ plan tests => 75; > > C4::Context->set_preference('ItemsDeniedRenewal',''); > # Generate test biblio >@@ -606,6 +606,19 @@ subtest "CanBookBeRenewed tests" => sub { > is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' ); > is( $error, 'auto_too_soon', > 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' ); >+ AddReserve( >+ $branch, $reserving_borrowernumber, $biblio->biblionumber, >+ $bibitems, $priority, $resdate, $expdate, $notes, >+ 'a title', $item_4->itemnumber, $found >+ ); >+ ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber ); >+ is( $renewokay, 0, 'Still should not be able to renew' ); >+ is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked' ); >+ ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 ); >+ is( $renewokay, 0, 'Still should not be able to renew' ); >+ is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' ); >+ >+ > > # Bug 7413 > # Test premature manual renewal >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19014
:
65590
|
86960
|
90509
|
95348
|
95851
|
95852
|
96688
|
96689
|
97374
|
97395
|
97396
|
97397
|
98704
|
98705
|
98706
|
98717
|
98718
|
98719
|
98720
|
100180