Bugzilla – Attachment 97455 Details for
Bug 7468
Add label to batch by barcode range
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7468: Fix 'false' message on Firefox
Bug-7468-Fix-false-message-on-Firefox.patch (text/plain), 1.93 KB, created by
Maryse Simard
on 2020-01-16 15:56:28 UTC
(
hide
)
Description:
Bug 7468: Fix 'false' message on Firefox
Filename:
MIME Type:
Creator:
Maryse Simard
Created:
2020-01-16 15:56:28 UTC
Size:
1.93 KB
patch
obsolete
>From 8c8ce4b46cd833535898a8d15f58bb5c842f8ec7 Mon Sep 17 00:00:00 2001 >From: David Bourgault <david.bourgault@inlibro.com> >Date: Wed, 4 Oct 2017 09:12:11 -0400 >Subject: [PATCH] Bug 7468: Fix 'false' message on Firefox > >It seems I was using an href to a javascript function in the 'Print Range' button, which Chrome didn't mind, but Firefox did understand. >--- > .../prog/en/modules/labels/label-edit-range.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt >index 79a21610f1..b3b7c7e8ab 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt >@@ -11,9 +11,9 @@ > str += "from=" + parseInt(document.getElementById("from-input").value) + "&"; > str += "to=" + parseInt(document.getElementById("to-input").value); > return GB_showCenter('Export labels', "/cgi-bin/koha/labels/label-print.pl?" + str, 400, 800); >- return; > } >- function print() { >+ >+ function validate() { > var error = false; > if (parseInt(document.getElementById("from-input").value) == 0) { > document.getElementById("from-error").innerHTML = " *Cannot be smaller than 1"; >@@ -80,7 +80,7 @@ > </div> > </form> > <div id="batch-manage" class="btn-toolbar"> >- <a class="btn btn-default btn-sm" id="print" href="javascript:print()"> >+ <a class="btn btn-default btn-sm" id="print" onClick="validate()"> > <!-- This display a plus. Is there a more appropriate symbol to use? > <i class="fa fa-plus"></i> > --> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7468
:
67184
|
67598
|
67636
|
70980
|
77592
|
81071
|
81072
|
81073
|
81074
|
81075
|
91568
|
91569
|
91570
|
97454
|
97455
|
97456
|
97457
|
97458
|
97459
|
97460
|
97461
|
97551
|
97552
|
97553
|
97554
|
97555
|
97556
|
97557
|
97558
|
97638
|
97639
|
97640
|
97641
|
97642
|
97643
|
97644
|
97645
|
97646