Attachment 97595 Details for Bug 24449 – Bug 24449: Add too_many_overdue to patron status for SIP

[patch] Bug 24449: Add too_many_overdue to patron status for SIP

Bug-24449-Add-toomanyoverdue-to-patron-status-for-.patch (text/plain), 1.96 KB, created by David Nind on 2020-01-20 02:06:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-01-20 02:06:30 UTC

Size: 1.96 KB

patch

obsolete

>From 753c61b1199c14aa9e7628515b67d38a4ccc3359 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 17 Jan 2020 14:29:42 +0000
>Subject: [PATCH] Bug 24449: Add too_many_overdue to patron status for SIP
>
>To test:
>1 - Have sip running and use the cli to get info for a patron
>    example: perl misc/sip_cli_emulator.pl  -a localhost -p 6001 -su koha -sp koha -l CPL -m patron_status_request --patron koha
>2 - Checkout an item to the patron, backdated so it is overdue
>3 - Set syspref 'OverduesBlockCirc' to anything but "Don't Block"
>4 - Get the patron status via SIP, note circ blocked flag is set, but too_many_overdue is not
>5 - Apply patch
>6 - Restart all the things
>7 - Get the patron status via SIP
>8 - Note the too_many_overdue flag is now triggered and there is a message
>    example: READ: 24Y     Y       00120200117    142716AEEdna Acosta|AA23529001000463|BLY|CQN|BV0.25|AFGreetings from Koha.  -- Patron has overdues -- Patron owes 0.25|AOCPL|
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/SIP/ILS/Patron.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
>index 497ec98771..4279b395d6 100644
>--- a/C4/SIP/ILS/Patron.pm
>+++ b/C4/SIP/ILS/Patron.pm
>@@ -107,6 +107,7 @@ sub new {
>         items           => [],
>         hold_items      => $flags->{WAITING}->{itemlist},
>         overdue_items   => $flags->{ODUES}->{itemlist},
>+        too_many_overdue => $circ_blocked,
>         fine_items      => [],
>         recall_items    => [],
>         unavail_holds   => [],
>@@ -121,6 +122,9 @@ sub new {
>     if ( $patron->is_debarred and $patron->debarredcomment ) {
>         $ilspatron{screen_msg} .= " -- " . $patron->debarredcomment;
>     }
>+    if ( $circ_blocked ) {
>+        $ilspatron{screen_msg} .= " -- " . "Patron has overdues";
>+    }
>     for (qw(EXPIRED CHARGES CREDITS GNA LOST DBARRED NOTES)) {
>         ($flags->{$_}) or next;
>         if ($_ ne 'NOTES' and $flags->{$_}->{message}) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24449: 97527 | 97595 | 98462