Bugzilla – Attachment 97655 Details for
Bug 22898
Selenium tests for placing holds from the staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22898: Since bug 23957, submit element is now a button (no longer input)
Bug-22898-Since-bug-23957-submit-element-is-now-a-.patch (text/plain), 1.57 KB, created by
Jonathan Druart
on 2020-01-21 11:58:37 UTC
(
hide
)
Description:
Bug 22898: Since bug 23957, submit element is now a button (no longer input)
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-21 11:58:37 UTC
Size:
1.57 KB
patch
obsolete
>From 97299be2a0669264a22bd951b53a0029a516a3ff Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Jan 2020 12:56:22 +0100 >Subject: [PATCH] Bug 22898: Since bug 23957, submit element is now a button > (no longer input) > >--- > t/db_dependent/selenium/basic_workflow.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index e3f62fd0bf..d5aa691d3f 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -241,13 +241,13 @@ SKIP: { > > #Place holds > $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[0]); >- $driver->find_element('//form[@id="hold-request-form"]//input[@type="submit"]')->click; # Biblio level >+ $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click; # Biblio level > my $patron = Koha::Patrons->find($borrowernumber); > is( $patron->holds->count, 1, ); > > $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[1]); > $driver->find_element('//form[@id="hold-request-form"]//input[@type="radio"]')->click; # Item level, there is only 1 item per bib so we are safe >- $driver->find_element('//form[@id="hold-request-form"]//input[@type="submit"]')->click; >+ $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click; > is( $patron->holds->count, 2, ); > > time_diff("holds"); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22898
:
89673
|
90208
|
90241
|
97655
|
97656
|
98877
|
98878
|
98879
|
98880
|
98881
|
98882