Attachment 97718 Details for Bug 24345 – Bug 24345: Fix OPACViewOthersSuggestions

[patch] Bug 24345: Fix OPACViewOthersSuggestions

Bug-24345-Fix-OPACViewOthersSuggestions.patch (text/plain), 1.40 KB, created by Marcel de Rooy on 2020-01-22 12:47:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-01-22 12:47:24 UTC

Size: 1.40 KB

patch

obsolete

>From bee88e717d3a445ecf52c772b2abf23fde890834 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 21 Jan 2020 10:26:04 +0100
>Subject: [PATCH] Bug 24345: Fix OPACViewOthersSuggestions
>Content-Type: text/plain; charset=utf-8
>
>Default value for $op needs to be set before the get_template_and_user lines as
>it's tested for OPACViewOthersSuggestions.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-suggestions.pl | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
>index a2e4d1439e..1ac168c0f2 100755
>--- a/opac/opac-suggestions.pl
>+++ b/opac/opac-suggestions.pl
>@@ -36,7 +36,7 @@ use Koha::Patrons;
> use Koha::DateUtils qw( dt_from_string );
> 
> my $input           = new CGI;
>-my $op              = $input->param('op');
>+my $op              = $input->param('op') || 'else';
> my $biblionumber    = $input->param('biblionumber');
> my $suggestion      = $input->Vars;
> my $negcaptcha      = $input->param('negcap');
>@@ -84,7 +84,6 @@ else {
> # DBIx::Class::Row::store_column(): No such column 'negcap' on Koha::Schema::Result::Suggestion at  Koha/C4/Suggestions.pm
> delete $suggestion->{negcap};
> delete $suggestion->{$_} foreach qw<op suggested_by_anyone confirm>;
>-$op = 'else' unless $op;
> 
> if ( $op eq 'else' ) {
>     if ( C4::Context->preference("OPACViewOthersSuggestions") ) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24345: 96829 | 96830 | 97651 | 97717 | 97718