Attachment 97732 Details for Bug 24478 – Bug 24478: Use `EnablePointOfSale` preference

[patch] Bug 24478: Use `EnablePointOfSale` preference

Bug-24478-Use-EnablePointOfSale-preference.patch (text/plain), 3.38 KB, created by ByWater Sandboxes on 2020-01-22 14:05:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2020-01-22 14:05:32 UTC

Size: 3.38 KB

patch

obsolete

>From ac43aef9513bf0e5947647d0f2c32a653fea008b Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 22 Jan 2020 10:51:55 +0000
>Subject: [PATCH] Bug 24478: Use `EnablePointOfSale` preference
>
>This patch adds the `EnablePointOfSale` preference to the accounting tab
>on the preferences editor and ties the display of the Point of Sale
>module to it.
>
>Test plan:
>1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences.
>2) Ensure you are a superuser or your user has the
>   takepayment permission.
>3) The Point of Sale module should be present on your staff home page
>   with the above configuration, otherwhise it should not.
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=24477
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>---
> .../en/modules/admin/preferences/accounting.pref   | 22 +++++++++++++++-------
> .../intranet-tmpl/prog/en/modules/intranet-main.tt |  2 +-
> 2 files changed, 16 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
>index e990b26bd9..36241161b9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/accounting.pref
>@@ -1,13 +1,6 @@
> Accounting:
>     Policy:
>         -
>-            - pref: UseCashRegisters
>-              default: no
>-              choices:
>-                yes: "Use"
>-                no: "Don't use"
>-            - " cash registers with the accounting system to track payments."
>-        -
>             - pref: AccountAutoReconcile
>               choices:
>                   yes: "Do"
>@@ -19,3 +12,18 @@ Accounting:
>                   yes: "Do"
>                   no: "Don't"
>             - automatically display a print dialog for a payment receipt when making a payment.
>+    Features:
>+        -
>+            - pref: UseCashRegisters
>+              default: no
>+              choices:
>+                yes: "Use"
>+                no: "Don't use"
>+            - " cash registers with the accounting system to track payments."
>+        -
>+            - pref: EnablePointOfSale
>+              default: no
>+              choices:
>+                yes: "Enable"
>+                no: "Disable"
>+            - " the point of sale feature to allow anonymous transactions with the accounting system. (Requires UseCashRegisters)"
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>index ac800c40c4..4cda8c1d2a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
>@@ -80,7 +80,7 @@
>                     <div class="col-xs-6">
>                         <ul class="biglinks-list">
> 
>-                            [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_takepayment ) %]
>+                            [% IF ( Koha.Preference('EnablePointOfSale') && Koha.Preference('UseCashRegisters') && CAN_user_cash_management_takepayment ) %]
>                             <li>
>                                 <a class="icon_general icon_pos" href="/cgi-bin/koha/pos/pay.pl"><i class="fa fa-shopping-cart"></i>Point of sale</a>
>                             </li>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24478: 97702 | 97703 | 97732 | 97733 | 97762 | 97763 | 97764