Bugzilla – Attachment 97839 Details for
Bug 21674
Data integrity not enforced for library groups
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21674: Remove duplicates from library_groups before adding the uniq constraint
Bug-21674-Remove-duplicates-from-librarygroups-bef.patch (text/plain), 1.43 KB, created by
Nick Clemens (kidclamp)
on 2020-01-23 18:17:09 UTC
(
hide
)
Description:
Bug 21674: Remove duplicates from library_groups before adding the uniq constraint
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-01-23 18:17:09 UTC
Size:
1.43 KB
patch
obsolete
>From f394df515f164264c5d93cb5bdb99c09d692b068 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Jan 2020 15:01:51 +0100 >Subject: [PATCH] Bug 21674: Remove duplicates from library_groups before > adding the uniq constraint > >To avoid to make it fails if duplicates existed prior to this change > >Credit for the SQL query goes to Nick, thanks! > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > installer/data/mysql/atomicupdate/bug_21674.perl | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/installer/data/mysql/atomicupdate/bug_21674.perl b/installer/data/mysql/atomicupdate/bug_21674.perl >index 3bcf5f9f76..418f3f5d24 100644 >--- a/installer/data/mysql/atomicupdate/bug_21674.perl >+++ b/installer/data/mysql/atomicupdate/bug_21674.perl >@@ -2,6 +2,16 @@ $DBversion = 'XXX'; # will be replaced by the RM > if( CheckVersion( $DBversion ) ) { > if( !index_exists( 'library_groups', 'library_groups_uniq_2' ) ) { > $dbh->do(q| >+ DELETE FROM library_groups >+ WHERE id NOT IN ( >+ SELECT MIN(id) >+ FROM library_groups >+ WHERE parent_id IS NOT NULL >+ GROUP BY parent_id, branchcode >+ ) >+ AND parent_id IS NOT NULL; >+ |); >+ $dbh->do(q| > ALTER TABLE library_groups > ADD UNIQUE KEY library_groups_uniq_2 (parent_id, branchcode) > |); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21674
:
96199
|
96200
|
97658
|
97667
|
97811
|
97837
|
97838
|
97839
|
98170
|
98171
|
98172
|
98224