Bugzilla – Attachment 97864 Details for
Bug 24507
Checkouts/ReturnClaim.t is failing on MySQL 8
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24507: Make Checkouts/ReturnClaim.t pass on MySQL 8
Bug-24507-Make-CheckoutsReturnClaimt-pass-on-MySQL.patch (text/plain), 1.47 KB, created by
Jonathan Druart
on 2020-01-24 10:15:49 UTC
(
hide
)
Description:
Bug 24507: Make Checkouts/ReturnClaim.t pass on MySQL 8
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-24 10:15:49 UTC
Size:
1.47 KB
patch
obsolete
>From b2ea1c0db67d43eb883b0f754eec19377d516898 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 24 Jan 2020 11:13:53 +0100 >Subject: [PATCH] Bug 24507: Make Checkouts/ReturnClaim.t pass on MySQL 8 > > $ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t > t/db_dependent/Koha/Checkouts/ReturnClaim.t .. > # Failed test 'Exception field is correct' > # at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 97. > # got: 'return_claims.issue_id' > # expected: 'issue_id' > # Looks like you failed 1 test of 8. > t/db_dependent/Koha/Checkouts/ReturnClaim.t .. 1/1 > # Failed test 'store() tests' > # at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 133. > >This is similar to bug 23825. > >Test plan: >Confirm that the tests pass on MySQL8 and MariaDB >--- > t/db_dependent/Koha/Checkouts/ReturnClaim.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Checkouts/ReturnClaim.t b/t/db_dependent/Koha/Checkouts/ReturnClaim.t >index ef03875bad..7d6c3bb4cc 100644 >--- a/t/db_dependent/Koha/Checkouts/ReturnClaim.t >+++ b/t/db_dependent/Koha/Checkouts/ReturnClaim.t >@@ -94,9 +94,9 @@ subtest "store() tests" => sub { > 'An exception is thrown on duplicate issue_id'; > close STDERR; > >- is( >+ like( > $@->duplicate_id, >- 'issue_id', >+ qr/(return_claims\.)?issue_id/, > 'Exception field is correct' > ); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24507
:
97864
|
97876