Attachment 97868 Details for Bug 24305 – Bug 24305: Remove previous declaration of batch_biblionumbers

[patch] Bug 24305: Remove previous declaration of batch_biblionumbers

Bug-24305-Remove-previous-declaration-of-batchbibl.patch (text/plain), 4.02 KB, created by Marcel de Rooy on 2020-01-24 11:27:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-01-24 11:27:46 UTC

Size: 4.02 KB

patch

obsolete

>From cc4add6f190b9b0deedd281f8c9a97fc250cc592 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 13 Jan 2020 12:15:33 +0100
>Subject: [PATCH] Bug 24305: Remove previous declaration of batch_biblionumbers
>Content-Type: text/plain; charset=utf-8
>
>We should not init batch_biblionumbers before.
>Also this patch deals with batch_cardnumbers.
>
>Signed-off-by: Holly Cooper <hc@interleaf.ie>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt   | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 95964dac69..37ea33a66b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -738,7 +738,7 @@ canned reports and writing custom SQL reports.</p>
>             <input type="hidden" name="recordtype" value="biblio" />
>             <input type="hidden" name="op" value="list" />
>             [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>-            <textarea style="display:none" name="recordnumber_list" id="recordnumber_list">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'biblionumber' || header_types.item(header_row.$place.cell) == 'biblionumber' %][% SET batch_biblionumbers = 1 %]
>+            <textarea style="display:none" name="recordnumber_list" id="recordnumber_list">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'biblionumber' || header_types.item(header_row.$place.cell) == 'biblionumber' %]
> [% cells.cell | html %][% END %][% END %][% END %]</textarea>
>         </form>
> 
>@@ -746,7 +746,7 @@ canned reports and writing custom SQL reports.</p>
>             <input type="hidden" name="recordtype" value="biblio" />
>             <input type="hidden" name="op" value="list" />
>             [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>-            <textarea style="display:none" name="recordnumber_list" id="recordnumber_list">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'biblionumber' || header_types.item(header_row.$place.cell) == 'biblionumber' %][% SET batch_biblionumbers = 1 %]
>+            <textarea style="display:none" name="recordnumber_list" id="recordnumber_list">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'biblionumber' || header_types.item(header_row.$place.cell) == 'biblionumber' %]
> [% cells.cell | html %][% END %][% END %][% END %]</textarea>
>         </form>
> 
>@@ -798,7 +798,7 @@ canned reports and writing custom SQL reports.</p>
>         <form method="POST" action="/cgi-bin/koha/tools/modborrowers.pl" id="batch_patron_modification">
>             <input type="hidden" name="op" value="show" />
>             [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>-            <textarea style="display:none" name="cardnumberlist" id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' %][% SET batch_cardnumbers = 1 %]
>+            <textarea style="display:none" name="cardnumberlist" id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' && cells.cell.match('^(\d+)$') %][% SET batch_cardnumbers = 1 %]
> [% cells.cell | html %][% END %][% END %][% END %]</textarea>
>         </form>
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24305: 96629 | 97302 | 97829 | 97866 | 97867 | 97868 | 97869 | 97870 | 98057