Attachment 97869 Details for Bug 24305 – Bug 24305: (follow-up) Add small comment for square brackets in get_prepped_report

[patch] Bug 24305: (follow-up) Add small comment for square brackets in get_prepped_report

Bug-24305-follow-up-Add-small-comment-for-square-b.patch (text/plain), 1.09 KB, created by Marcel de Rooy on 2020-01-24 11:27:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-01-24 11:27:50 UTC

Size: 1.09 KB

patch

obsolete

>From 2ad7ff748fef282f8aa7cdb8b9b011b7069121c0 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 24 Jan 2020 11:04:05 +0000
>Subject: [PATCH] Bug 24305: (follow-up) Add small comment for square brackets
> in get_prepped_report
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> reports/guided_reports.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index 3cae7cd546..5059e9502a 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -1083,6 +1083,9 @@ sub get_prepped_report {
>     my ($sql, $param_names, $sql_params ) = @_;
> 
>     # First we split out the placeholders
>+    # This part of the code supports using [[ table.field | alias ]] in the
>+    # query and replaces it by table.field AS alias. Not sure why we would
>+    # need it if we can type the latter (which is simpler)?
>     my @split = split /\[\[|\]\]/,$sql;
>     my $headers;
>     for(my $i=0;$i<$#split/2;$i++){ #The placeholders are always the odd elements of the array
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24305: 96629 | 97302 | 97829 | 97866 | 97867 | 97868 | 97869 | 97870 | 98057