Bugzilla – Attachment 97899 Details for
Bug 23463
Move C4::Items CRUD subroutines to Koha::Item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23463: Remove _set_defaults_for_add
Bug-23463-Remove-setdefaultsforadd.patch (text/plain), 2.32 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-01-24 19:44:57 UTC
(
hide
)
Description:
Bug 23463: Remove _set_defaults_for_add
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-01-24 19:44:57 UTC
Size:
2.32 KB
patch
obsolete
>From f81cbb78a2242a392b75c7f8ce073e8456349d6b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 18 Mar 2019 14:15:37 -0300 >Subject: [PATCH] Bug 23463: Remove _set_defaults_for_add > >_set_defaults_for_add is no longer needed as it is handled by dbic and koha::object->store >--- > C4/Items.pm | 43 ------------------------------------------- > Koha/Item.pm | 4 ++++ > 2 files changed, 4 insertions(+), 43 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index db0339c355..5be5ee9b0b 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -202,7 +202,6 @@ sub AddItem { > $unlinked_item_subfields = shift; > } > >- _set_defaults_for_add($item); > _set_derived_columns_for_add($item); > $item->{'more_subfields_xml'} = _get_unlinked_subfields_xml($unlinked_item_subfields); > >@@ -304,7 +303,6 @@ sub AddItemBatchFromMarc { > next ITEMFIELD; > } > >- _set_defaults_for_add($item); > _set_derived_columns_for_add($item); > my ( $itemnumber, $error ) = _koha_new_item( $item, $item->{barcode} ); > warn $error if $error; >@@ -1486,47 +1484,6 @@ sub _calc_items_cn_sort { > $item->{'items.cn_sort'} = GetClassSort($source_values->{'items.cn_source'}, $source_values->{'itemcallnumber'}, ""); > } > >-=head2 _set_defaults_for_add >- >- _set_defaults_for_add($item_hash); >- >-Given an item hash representing an item to be added, set >-correct default values for columns whose default value >-is not handled by the DBMS. This includes the following >-columns: >- >-=over 2 >- >-=item * >- >-C<items.dateaccessioned> >- >-=item * >- >-C<items.notforloan> >- >-=item * >- >-C<items.damaged> >- >-=item * >- >-C<items.itemlost> >- >-=item * >- >-C<items.withdrawn> >- >-=back >- >-=cut >- >-sub _set_defaults_for_add { >- my $item = shift; >- $item->{dateaccessioned} ||= output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); >- $item->{$_} ||= 0 for (qw( notforloan damaged itemlost withdrawn)); >-} >- > =head2 _koha_new_item > > my ($itemnumber,$error) = _koha_new_item( $item, $barcode ); >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 60d8f935b1..5a6d0c0cc8 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -81,6 +81,10 @@ sub store { > > } > >+ unless ( $self->dateaccessioned ) { >+ $self->dateaccessioned($today); >+ } >+ > return $self->SUPER::store; > } > >-- >2.25.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23463
:
95899
|
95900
|
95901
|
95902
|
95903
|
95904
|
95905
|
95906
|
95907
|
95908
|
95909
|
95910
|
95911
|
95912
|
95913
|
95914
|
95915
|
95916
|
95917
|
95918
|
95919
|
95920
|
95921
|
95922
|
95923
|
95925
|
96145
|
97895
|
97896
|
97897
|
97898
|
97899
|
97900
|
97901
|
97902
|
97903
|
97904
|
97905
|
97906
|
97907
|
97908
|
97909
|
97910
|
97911
|
97912
|
97913
|
97914
|
97915
|
97916
|
97917
|
97918
|
97919
|
97920
|
97921
|
101151
|
101152
|
101153
|
101154
|
101156
|
101157
|
101158
|
101161
|
101163
|
101165
|
101167
|
101169
|
101170
|
101171
|
101172
|
101173
|
101174
|
101175
|
101176
|
101177
|
101178
|
101179
|
101180
|
101181
|
101182
|
101183
|
101184
|
101185
|
101186
|
101188
|
101189
|
101190
|
101191
|
101192
|
101193
|
101194
|
101195
|
101196
|
101197
|
101246
|
101247
|
101248
|
101249
|
101250
|
101251
|
101252
|
101253
|
101254
|
101255
|
101256
|
101257
|
101258
|
101259
|
101260
|
101261
|
101262
|
101263
|
101264
|
101265
|
101266
|
101267
|
101268
|
101269
|
101270
|
101271
|
101272
|
101273
|
101274
|
101275
|
101276
|
101277
|
101278
|
101279
|
101280
|
101281
|
101282
|
101283
|
101284
|
101413
|
101414
|
101415
|
101416
|
101432
|
101476
|
102071
|
103129
|
113581