Attachment 97940 Details for Bug 24515 – Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly

[patch] Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly

Bug-24515-Column-Configuration-for-pay-fines-table.patch (text/plain), 1.55 KB, created by Katrin Fischer on 2020-01-25 17:45:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-01-25 17:45:54 UTC

Size: 1.55 KB

patch

obsolete

>From e851d45667d7bcaa4bb0e15584ea0104e85aa7c8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 24 Jan 2020 23:25:20 +0000
>Subject: [PATCH] Bug 24515: Column Configuration for pay-fines-table does not
> hide Account Type properly
>
>This patch corrects the order of the columns in the columns
>configuration YML file. The incorrect order was causing the wrong column
>to be hidden when changing the columns settings for the table in
>Administration.
>
>To test, apply the patch and go to Administration -> Columns settings.
>
> - Under Patrons -> pay-fines-table, test hiding the account_type and
>   description columns, together and separately.
> - Verify that the correct columns are hidden on the pay fines screen
>   (Patron -> Accounting -> Make a payment)
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> admin/columns_settings.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
>index f604f7925e..2bb203c345 100644
>--- a/admin/columns_settings.yml
>+++ b/admin/columns_settings.yml
>@@ -550,6 +550,8 @@ modules:
>           cannot_be_toggled: 1
>           cannot_be_modified: 1
>         -
>+          columnname: account_type
>+        -
>           columnname: description
>         -
>           columnname: date
>@@ -562,8 +564,6 @@ modules:
>         -
>           columnname: note
>         -
>-          columnname: account_type
>-        -
>           columnname: amount
>         -
>           columnname: amountoutstanding
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24515: 97931 | 97933 | 97940