Attachment 97954 Details for Bug 24475 – Bug 24475: Reword FinesMode system preference

[patch] Bug 24475: Reword FinesMode system preference

Bug-24475-Reword-FinesMode-system-preference.patch (text/plain), 2.79 KB, created by David Roberts on 2020-01-27 02:05:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Roberts

Created: 2020-01-27 02:05:38 UTC

Size: 2.79 KB

patch

obsolete

>From d4507e600cf1e05b5bf916e6a8d5a6418100888e Mon Sep 17 00:00:00 2001
>From: David Roberts <david@koha-ptfs.co.uk>
>Date: Mon, 27 Jan 2020 02:04:33 +0000
>Subject: [PATCH] Bug 24475: Reword FinesMode system preference
>
>This patch changes the wording of the FinesMode and
>CalculateFinesOnReturn syste
>m preferences explanations
>
>1) Install Patch
>2) Check that the wording of the FinesMode system preference has changed
>to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing
>and final fines will be calculated when the cron runs and accruing fines
>will be finalized when an item is returned. If CalculateFinesOnReturn is
>enabled, final fines will be calculated when an item is returned."
>3) Check that the wording of the CalculateFinesOnReturn system
>preference has changed to add "NOTE: This system preference requires
>FinesMode to be set to 'Calculate and charge.'" to the existing note.
>---
> .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 6eb5af0660..e7e7b9ca16 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -531,6 +531,7 @@ Circulation:
> no: "Don't"
> - calculate and update overdue charges when an item is returned.
> - " NOTE: If you are doing hourly loans then you should have this on."
>+ - " NOTE: This system preference requires FinesMode to be set to 'Calculate and charge.'."
> -
> - pref: UpdateItemLocationOnCheckin
> type: textarea
>@@ -857,8 +858,7 @@ Circulation:
> test: Calculate (but only for mailing to the admin)
> production: Calculate and charge
> - fines (when <code>misc/cronjobs/fines.pl</code> is being run).
>- - " NOTE: Fines can also be charged by the CalculateFinesOnReturn system preference."
>- - " NOTE: This system preference requires the <code>misc/cronjobs/fines.pl</code> cronjob. Ask your system administrator to schedule it."
>+ - " NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If CalculateFinesOnReturn is enabled, final fines will be calculated when an item is returned."
> -
> - If a lost item is returned, apply the refunding rules defined in the
> - pref: RefundLostOnReturnControl
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24475: 97954 | 97984 | 99003 | 101780 | 101800 | 101811 | 101812