Bugzilla – Attachment 97991 Details for
Bug 24361
Fix warnings (or failing tests) from bug 24217
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24361: Silent t/db_dependent/Items.t
Bug-24361-Silent-tdbdependentItemst.patch (text/plain), 1.11 KB, created by
Jonathan Druart
on 2020-01-27 16:44:15 UTC
(
hide
)
Description:
Bug 24361: Silent t/db_dependent/Items.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-27 16:44:15 UTC
Size:
1.11 KB
patch
obsolete
>From e8a78cf0b19efc313fca495e3bae4d3df8505462 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 27 Jan 2020 17:43:17 +0100 >Subject: [PATCH] Bug 24361: Silent t/db_dependent/Items.t > >its output is displaying tons of >Use of uninitialized value $field in regexp compilation at /kohadevbox/koha/C4/Items.pm line 2106. >--- > C4/Items.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 498c3eb43c..925afc2397 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2102,7 +2102,7 @@ sub _SearchItems_build_where_fragment { > push @columns, Koha::Database->new()->schema()->resultset('Biblio')->result_source->columns; > push @columns, Koha::Database->new()->schema()->resultset('Biblioitem')->result_source->columns; > my @operators = qw(= != > < >= <= like); >- my $field = $filter->{field}; >+ my $field = $filter->{field} // q{}; > if ( (0 < grep /^$field$/, @columns) or (substr($field, 0, 5) eq 'marc:') ) { > my $op = $filter->{operator}; > my $query = $filter->{query}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24361
:
96873
|
96892
|
96969
|
97315
| 97991 |
98796