Bugzilla – Attachment 97993 Details for
Bug 24348
Record matching rules: required match checks does not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24348: Pass marc record to _passes_required_checks
Bug-24348-Pass-marc-record-to-passesrequiredchecks.patch (text/plain), 1.31 KB, created by
Martin Renvoize (ashimema)
on 2020-01-27 19:01:16 UTC
(
hide
)
Description:
Bug 24348: Pass marc record to _passes_required_checks
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-01-27 19:01:16 UTC
Size:
1.31 KB
patch
obsolete
>From 3c3c561eb30a26911886ee33269ae41e39515b84 Mon Sep 17 00:00:00 2001 >From: Andreas Jonsson <andreas.jonsson@kreablo.se> >Date: Sun, 5 Jan 2020 13:02:13 +0000 >Subject: [PATCH] Bug 24348: Pass marc record to _passes_required_checks > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Matcher.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Matcher.pm b/C4/Matcher.pm >index 84ceab2935..949920c7e1 100644 >--- a/C4/Matcher.pm >+++ b/C4/Matcher.pm >@@ -726,7 +726,7 @@ sub get_matches { > # get rid of any that don't meet the required checks > $matches = { > map { >- _passes_required_checks( $source_record, $_, $self->{'required_checks'} ) >+ _passes_required_checks( $source_record, $matches->{$_}->{'record'}, $self->{'required_checks'} ) > ? ( $_ => $matches->{$_} ) > : () > } keys %$matches >@@ -790,8 +790,7 @@ sub dump { > } > > sub _passes_required_checks { >- my ($source_record, $target_blob, $matchchecks) = @_; >- my $target_record = MARC::Record->new_from_usmarc($target_blob); # FIXME -- need to avoid parsing record twice >+ my ($source_record, $target_record, $matchchecks) = @_; > > # no checks supplied == automatic pass > return 1 if $#{ $matchchecks } == -1; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24348
:
96825
|
97993
|
98021