Bugzilla – Attachment 97994 Details for
Bug 13420
Holdings table sorting on volume information incorrect
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13420: Sort "Serial enumeration" by published date
Bug-13420-Sort-Serial-enumeration-by-published-dat.patch (text/plain), 2.99 KB, created by
Martin Renvoize (ashimema)
on 2020-01-27 19:19:05 UTC
(
hide
)
Description:
Bug 13420: Sort "Serial enumeration" by published date
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-01-27 19:19:05 UTC
Size:
2.99 KB
patch
obsolete
>From f1f5981105f582d9b3d5e0070c0b865bc1828a89 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 28 Apr 2019 22:53:55 -0400 >Subject: [PATCH] Bug 13420: Sort "Serial enumeration" by published date > >So far the sorting on volume information is incorrect. It sorts by the >string displayed in the cell, which may not have any logics. > >A better solution would be to use Kyle's suggestion, see comments 7, 8, >but it will need much more work. > >This patch suggests to use the publication date to sort this column. >Note: In the code there is a switch depending on the existence of >items.publisheddate, but I do not think it is valid, this valid should >always exist if the item is received (did I miss something?) > >Test plan: >You need to have different existing subscription, using different >numbering. >On the detail page of the bibliographic record you should be able to >sort the serials (tab "Holdings") by "Serial enumeration". >The sort will now use the publication dates. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 57f0352273..214d09c507 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -229,7 +229,7 @@ > <th>Home library</th> > [% IF ( itemdata_ccode ) %]<th>Collection</th>[% END %] > <th>Call number</th> >- [% IF ( volinfo ) %]<th>Serial enumeration / chronology</th>[% END %] >+ [% IF volinfo %]<th class="title-string">Serial enumeration / chronology</th>[% END %] > <th>Status</th> > <th class="title-string">Last seen</th> > <th class="title-string">Date accessioned</th> >@@ -286,6 +286,7 @@ Note that permanent location is a code, and location may be an authval. > <td class="itemcallnumber">[% IF ( item.itemcallnumber ) %] [% item.itemcallnumber | html %][% END %]</td> > [% IF ( volinfo ) %] > <td class="enumchron"> >+ <span title="[% item.publisheddate | html %]"> > [% IF ( itemdata_enumchron ) %] > [% IF item.enumchron && item.serialseq %] > <span class="enum">[% item.enumchron | html %]</span> >@@ -302,6 +303,7 @@ Note that permanent location is a code, and location may be an authval. > <span class="pubdate">([% item.publisheddate | $KohaDates %])</span> > [% END %] > [% END %] >+ </span> > </td> > [% END %] > <td class="status"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13420
:
34239
|
34240
|
47566
|
88995
|
92026
|
97994
|
97995
|
98511
|
98512
|
98513