Bugzilla – Attachment 98018 Details for
Bug 20388
Ability to add search fields from UI
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20388: QA fixe : add searchfield only if it doesn't exist
Bug-20388-QA-fixe--add-searchfield-only-if-it-does.patch (text/plain), 2.29 KB, created by
Alex Arnaud
on 2020-01-28 08:15:47 UTC
(
hide
)
Description:
Bug 20388: QA fixe : add searchfield only if it doesn't exist
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2020-01-28 08:15:47 UTC
Size:
2.29 KB
patch
obsolete
>From 724f73f1dd5f94f2f633768eb17d08c4f82d53e9 Mon Sep 17 00:00:00 2001 >From: Axel Amghar <axel.amghar@biblibre.com> >Date: Fri, 17 May 2019 14:24:52 +0200 >Subject: [PATCH] Bug 20388: QA fixe : add searchfield only if it doesn't exist > >To test: > >Without the fix: >- in search field configuration -> search field >- add the search field "uri" at the bottom of the tab >- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg > >Then apply the fix >- try to add the search field uri >- this time an alert should appear with the message : >" SearchField uri already exist " > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > .../admin/searchengine/elasticsearch/mappings.tt | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >index 68408df..4c0f319 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt >@@ -81,11 +81,19 @@ > var table = $(this).closest('table'); > var line = $(this).closest("tr"); > var name = $(line).find('input[data-id="search_field_name"]').val(); >- var label = $(line).find('input[data-id="search_field_name"]').val(); >- if ( name.length > 0 && label.length > 0 ) { >- var new_line = clone_line( line ); >- new_line.appendTo(table.find('tbody')); >- clean_line(line); >+ let already_exist = 0; >+ [% FOREACH search_field IN all_search_fields %] >+ if ("[% search_field.name | html %]" == name){ already_exist = 1; } >+ [% END %] >+ if (already_exist) { >+ alert("SearchField "+ name + " already exist"); >+ } else { >+ var label = $(line).find('input[data-id="search_field_name"]').val(); >+ if ( name.length > 0 && label.length > 0 ) { >+ var new_line = clone_line( line ); >+ new_line.appendTo(table.find('tbody')); >+ clean_line(line); >+ } > } > }); > }); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20388
:
73158
|
73165
|
73167
|
73476
|
73626
|
73627
|
73629
|
73681
|
73682
|
73918
|
73919
|
73940
|
73943
|
73944
|
73945
|
73946
|
74261
|
74718
|
74719
|
78658
|
78659
|
80709
|
86912
|
87196
|
87197
|
87198
|
87199
|
87201
|
87202
|
87203
|
87204
|
88075
|
88079
|
88080
|
88081
|
88082
|
88083
|
89117
|
89118
|
89121
|
89733
|
89894
|
90517
|
90518
|
90519
|
90520
|
90521
|
90522
|
90523
|
90524
|
98011
|
98012
|
98013
|
98014
|
98015
|
98016
|
98017
|
98018
|
99960
|
99961
|
99962
|
99963
|
99964
|
99965
|
99966
|
99967
|
119296
|
119317
|
119318
|
120104
|
163449
|
163450
|
163451
|
163452
|
163460
|
163461
|
163462
|
163463
|
164529
|
164530
|
164531
|
164532
|
164533
|
164534
|
164535
|
164789
|
164790
|
164791
|
164792
|
164793