Bugzilla – Attachment 9803 Details for
Bug 7751
Decrease loan period on items with a high number of holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Updates HIGHHOLDS data-structure.
0002-Bug-7751-HIGHHOLDS-should-be-a-single-datastructure.patch (text/plain), 2.53 KB, created by
Martin Renvoize (ashimema)
on 2012-05-28 14:08:52 UTC
(
hide
)
Description:
Updates HIGHHOLDS data-structure.
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2012-05-28 14:08:52 UTC
Size:
2.53 KB
patch
obsolete
>From 1f2edbfb788f977e155d1957302596174812d170 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 29 Jun 2011 17:25:49 +0100 >Subject: [PATCH 2/3] Bug 7751 : HIGHHOLDS should be a single datastructure > >Data returned with HIGHHOLDS was being returned on the same >level as the flag so that it might be interpreted as further >items requiring confirmation. >Instead of HIGHHOLDS being returned as a flag return it as a >data structure containing that data. Change template to >reflect this > >Conflicts: > > C4/Circulation.pm >--- > C4/Circulation.pm | 9 +++++---- > .../prog/en/modules/circ/circulation.tt | 8 ++++---- > 2 files changed, 9 insertions(+), 8 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 670bd3d..b57455e 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -935,10 +935,11 @@ sub CanBookBeIssued { > #print "reserved: $reserved\n".Dumper($num); > if ($num>=C4::Context->preference("decreaseLoanHighHoldsValue")) > { >- $needsconfirmation{HIGHHOLDS} = 1; >- $needsconfirmation{'num_holds'} = $num; >- $needsconfirmation{'duration'} = $duration; >- $needsconfirmation{'returndate'} = format_date($returndate); >+ $needsconfirmation{HIGHHOLDS} = { >+ num_holds => $num, >+ duration => $duration, >+ returndate => format_date($returndate), >+ }; > } > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index cf75962..39153fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -285,15 +285,15 @@ function refocus(calendar) { > <li>This item has been lost with a status of "[% ITEM_LOST %]". Check out anyway?</li> > [% END %] > >-[% IF ( HIGHHOLDS ) %] >- <li>High demand item. Loan period shortened to [% duration %] days (due [% returndate %]). Check out anyway?</li> >+[% IF HIGHHOLDS %] >+ <li>High demand item. Loan period shortened to [% HIGHHOLDS.duration %] days (due [% HIGHHOLDS.returndate %]). Check out anyway?</li> > [% END %] > </ul> > >-[% IF ( HIGHHOLDS ) %] >+[% IF HIGHHOLDS %] > <script language="JavaScript" type="text/javascript"> > $(document).ready(function() { >- $("input[name=duedatespec]:hidden").val('[% returndate %]'); >+ $("input[name=duedatespec]:hidden").val('[% HIGHHOLDS.returndate %]'); > }); > </script> > [% END %] >-- >1.7.2.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7751
:
8313
|
8314
|
8315
|
9801
|
9803
|
9804
|
9810
|
9811
|
9812
|
9834
|
10040
|
10199
|
10204
|
11477
|
11672
|
11676
|
12337
|
12345
|
12528
|
12643
|
12786
|
12787
|
12802
|
12803