Bugzilla – Attachment 9804 Details for
Bug 7751
Decrease loan period on items with a high number of holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7751 : Selfcheckout should be aware of the Reduced Loan Periods
0003-Bug-7751-Self-Check-should-recognize-Reduced-Loan-Pe.patch (text/plain), 2.83 KB, created by
Martin Renvoize (ashimema)
on 2012-05-28 14:10:23 UTC
(
hide
)
Description:
Bug 7751 : Selfcheckout should be aware of the Reduced Loan Periods
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2012-05-28 14:10:23 UTC
Size:
2.83 KB
patch
obsolete
>From f5a5b92d4bd349ed437299a05301a0f4d2b83804 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Mon, 27 Jun 2011 12:15:50 +0100 >Subject: [PATCH 3/3] Bug 7751 : Self Check should recognize Reduced Loan Periods > >Staffs Reduced Loan feature returns the reduced >due date as 'needs confirm' Self Check should apply it as >due date when adding the issue > >Conflicts: > > C4/SIP/ILS/Transaction/Checkout.pm >--- > C4/SIP/ILS/Transaction/Checkout.pm | 10 +++++++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm >index d483e16..6cc3437 100644 >--- a/C4/SIP/ILS/Transaction/Checkout.pm >+++ b/C4/SIP/ILS/Transaction/Checkout.pm >@@ -55,6 +55,7 @@ sub do_checkout { > my $shelf = $self->{item}->hold_shelf; > my $barcode = $self->{item}->id; > my $patron_barcode = $self->{patron}->id; >+ my $overridden_duedate; # usually passed as undef to AddIssue > $debug and warn "do_checkout: patron (" . $patron_barcode . ")"; > my $borrower = $self->{patron}->getmemberdetails_object(); > $debug and warn "do_checkout borrower: . " . Dumper $borrower; >@@ -73,7 +74,7 @@ sub do_checkout { > $noerror = 0; > } > } else { >- foreach my $confirmation (keys %$needsconfirmation) { >+ foreach my $confirmation (keys %{$needsconfirmation}) { > if ($confirmation eq 'RENEW_ISSUE'){ > $self->screen_msg("Item already checked out to you: renewing item."); > } elsif ($confirmation eq 'RESERVED' or $confirmation eq 'RESERVE_WAITING') { >@@ -88,6 +89,9 @@ sub do_checkout { > $self->screen_msg("Item already checked out to another patron. Please return item for check-in."); > $noerror = 0; > } elsif ($confirmation eq 'DEBT') { # don't do anything, it's the minor debt, and alarms fire elsewhere >+ } elsif ($confirmation eq 'HIGHHOLDS') { >+ $overridden_duedate = $needsconfirmation->{$confirmation}->{returndate}; >+ $self->screen_msg('Loan period reduced for high-demand item'); > } else { > $self->screen_msg($needsconfirmation->{$confirmation}); > $noerror = 0; >@@ -119,10 +123,10 @@ sub do_checkout { > # TODO: adjust representation in $self->item > } > # can issue >- $debug and warn "do_checkout: calling AddIssue(\$borrower,$barcode, undef, 0)\n" >+ $debug and warn "do_checkout: calling AddIssue(\$borrower,$barcode, $overridden_duedate, 0)\n" > # . "w/ \$borrower: " . Dumper($borrower) > . "w/ C4::Context->userenv: " . Dumper(C4::Context->userenv); >- my $due_dt = AddIssue($borrower, $barcode, undef, 0); >+ my $due_dt = AddIssue($borrower, $barcode, $overridden_duedate, 0); > if ($due_dt) { > $self->{due} = $due_dt->clone(); > } else { >-- >1.7.2.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7751
:
8313
|
8314
|
8315
|
9801
|
9803
|
9804
|
9810
|
9811
|
9812
|
9834
|
10040
|
10199
|
10204
|
11477
|
11672
|
11676
|
12337
|
12345
|
12528
|
12643
|
12786
|
12787
|
12802
|
12803