Attachment 98057 Details for Bug 24305 – Bug 24305: (follow-up) Remove previous declaration of batch_biblionumbers

[patch] Bug 24305: (follow-up) Remove previous declaration of batch_biblionumbers

Bug-24305-follow-up-Remove-previous-declaration-of.patch (text/plain), 2.04 KB, created by Jonathan Druart on 2020-01-29 10:17:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-01-29 10:17:44 UTC

Size: 2.04 KB

patch

obsolete

>From 101ecf5a410571d9636a18f627a6161aed49ead6 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 29 Jan 2020 11:13:45 +0100
>Subject: [PATCH] Bug 24305: (follow-up) Remove previous declaration of
> batch_biblionumbers
>
>Revert change for cardnumbers, they are not always numbers.
>We may need to add a regex to remove special chars however, will be done
>on its own bug report if needed.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index d998265b36..210f340ddc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -798,7 +798,7 @@ canned reports and writing custom SQL reports.</p>
>         <form method="POST" action="/cgi-bin/koha/tools/modborrowers.pl" id="batch_patron_modification">
>             <input type="hidden" name="op" value="show" />
>             [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>-            <textarea style="display:none" name="cardnumberlist" id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' && cells.cell.match('^(\d+)$') %][% SET batch_cardnumbers = 1 %]
>+            <textarea style="display:none" name="cardnumberlist" id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN result.cells %][% place = loop.index %][% IF header_row.$place.cell == 'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' %][% SET batch_cardnumbers = 1 %]
> [% cells.cell | html %][% END %][% END %][% END %]</textarea>
>         </form>
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24305: 96629 | 97302 | 97829 | 97866 | 97867 | 97868 | 97869 | 97870 | 98057