Bugzilla – Attachment 98098 Details for
Bug 23594
Add ability to batch modify itemtypes from the suggestions page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23594: Add missing html filters
Bug-23594-Add-missing-html-filters.patch (text/plain), 2.84 KB, created by
Katrin Fischer
on 2020-01-29 22:02:34 UTC
(
hide
)
Description:
Bug 23594: Add missing html filters
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-01-29 22:02:34 UTC
Size:
2.84 KB
patch
obsolete
>From 1ce15819ae626529ee3bbbb8e3e7348659e14701 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 22 Jan 2020 10:04:21 +0100 >Subject: [PATCH] Bug 23594: Add missing html filters > >Also fixes the following QA failure: >forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 840) > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 11a5cbfe2d..76a78c5703 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -470,7 +470,7 @@ > <ul class="ui-tabs-nav"> > [% FOREACH suggestion IN suggestions %] > <li> >- <a href="#tab_[% loop.count %]"> >+ <a href="#tab_[% loop.count | uri %]"> > [% IF ( suggestion.suggestiontypelabel ) %] > [% IF (suggestion.suggestiontypelabel == "Pending") %]Pending > [% ELSIF (suggestion.suggestiontypelabel == "Accepted") %]Accepted >@@ -494,12 +494,12 @@ > [% END %] > > [% FOREACH suggestion IN suggestions %] >-<div id="tab_[% loop.count %]"> >-<form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#tab_[% loop.count %]"> >+<div id="tab_[% loop.count | html %]"> >+<form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#tab_[% loop.count | html %]"> > > [% IF ( suggestion.suggestions_loop ) %] > <p><a class="checkall" href="#">Check all</a> | <a class="uncheckall" href="#">Uncheck all</a></p> >- <table id="table_[% loop.count %]" class="sorted"> >+ <table id="table_[% loop.count | html %]" class="sorted"> > <thead> > <tr> > <th class="NoSort noExport"> </th> >@@ -645,7 +645,7 @@ > > <div class="col-sm-4"> > <fieldset> >- <label for="delete_[% loop.count %]">Delete selected</label> >+ <label for="delete_[% loop.count | html %]">Delete selected</label> > <input type="hidden" name="branchcode" value="[% branchfilter | html %]" /> > <fieldset class="action"><button type="submit" class="btn btn-default btn-xs" value="delete"/>Delete</button></fieldset> > </fieldset> >@@ -837,7 +837,7 @@ > [% INCLUDE 'columns_settings.inc' %] > [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] > >- <script type="text/javascript"> >+ <script> > $(document).ready(function() { > $('#suggestiontabs').tabs(); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23594
:
94469
|
94520
|
94521
|
94834
|
94835
|
94836
|
97663
|
97664
|
97665
|
97693
|
97781
|
98094
|
98095
|
98096
|
98097
| 98098 |
98099