Bugzilla – Attachment 98118 Details for
Bug 23493
jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23493: Fix selenium/regressions.t
Bug-23493-Fix-seleniumregressionst.patch (text/plain), 1.58 KB, created by
Jonathan Druart
on 2020-01-30 09:22:59 UTC
(
hide
)
Description:
Bug 23493: Fix selenium/regressions.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-30 09:22:59 UTC
Size:
1.58 KB
patch
obsolete
>From 14ac05346cf8e55d0bcf074762672e2100173c70 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 30 Jan 2020 10:20:25 +0100 >Subject: [PATCH] Bug 23493: Fix selenium/regressions.t > >One test wants to make sure thead, tfood and tbody will have th/td's >with the same size/number. >Existing test for tbody was retrieving the grouped td, which has a >colspan of 100%. Note that this 100% value seems to be wrong as it is >interpreted like "100" by the browser. We do not want to test this row >anyway, but the real row, the one with all the td's. > >This patch makes it retrieve the second tr and count the number of td it >has. >--- > t/db_dependent/selenium/regressions.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 1fec63172b..ed2a68cdd4 100644 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -181,9 +181,9 @@ subtest 'Display circulation table correctly' => sub { > my $tfoot_length = 0; > $tfoot_length += $_->get_attribute('colspan') || 0 for @tfoot_td; > >- my @tbody_td = $driver->find_elements('//table[@id="issues-table"]/tbody/tr/td'); >+ my @tbody_td = $driver->find_elements('//table[@id="issues-table"]/tbody/tr[2]/td'); > my $tbody_length = 0; >- $tbody_length += $_->get_attribute('colspan') || 0 for @tbody_td; >+ $tbody_length += 1 for @tbody_td; > > is( $thead_length == $tfoot_length && $tfoot_length == $tbody_length, > 1, "Checkouts table must be correctly aligned" ) >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23493
:
92443
|
92444
|
97324
|
97344
|
97694
|
97704
|
98041
|
98042
|
98055
|
98056
| 98118 |
98132